Created by field can't have null value

[BOHEUS]

Scenario:

1. Log in
2. Go to People, Companies or Opportunities

Actual: Created by field has no data at all in some cases

Expected: Created by field must have data, if anything occurs leading to showing or adding new record, then error should be thrown.

[FelixMalfait]

I think it does have data but the issue is the edit mode of the createdBy field which makes the value disappear

(we made createdBy nullable because we couldn't backfill some of the old data, but all new records should have a non-null createdBy)

[BOHEUS]

@FelixMalfait I checked it using REST API and records in:

• Opportunities have either createdBy filled with data of nonexistent creator 'Jony Ive' or null
  Fragment of Opportunities record

{
                "id": "20202020-0543-4cc2-9f96-95cc699960f2",
                "name": "Opportunity 2",
                "closeDate": "2024-08-07T21:44:31.821Z",
                "stage": "MEETING",
                "position": 2,
                "createdAt": "2024-08-07T21:44:31.819Z",
                "updatedAt": "2024-08-07T21:44:31.819Z",
                "pointOfContactId": "20202020-f517-42fd-80ae-14173b3b70ae",
                "companyId": "20202020-5d81-46d6-bf83-f7fd33ea6102",
                "amount": {
                    "amountMicros": 2000000,
                    "currencyCode": "USD"
                },
                "createdBy": {
                    "source": "MANUAL",
                    "workspaceMemberId": "20202020-77d5-4cb6-b60a-f4a835a85d61",
                    "name": "Jony Ive"
                },
...

• Companies and People also have null value

{
               "id": "20202020-1455-4c57-afaf-dd5dc086361d",
               "name": "Algolia",
               "employees": null,
               "idealCustomerProfile": false,
               "position": 13,
               "createdAt": "2024-08-07T21:44:31.819Z",
               "updatedAt": "2024-08-07T21:44:31.819Z",
               "accountOwnerId": null,
               "accountOwner": null,
               "tagline": "Algolia's tagline",
               "workPolicy": [
                   "ON_SITE"
               ],
               "visaSponsorship": false,
               "domainName": {
                   "primaryLinkLabel": "",
                   "primaryLinkUrl": "https://algolia.com",
                   "secondaryLinks": null
               },
               "linkedinLink": {
                   "primaryLinkLabel": "",
                   "primaryLinkUrl": "",
                   "secondaryLinks": null
               },
               "xLink": {
                   "primaryLinkLabel": "",
                   "primaryLinkUrl": "",
                   "secondaryLinks": null
               },
               "annualRecurringRevenue": {
                   "amountMicros": null,
                   "currencyCode": ""
               },
               "address": {
                   "addressStreet1": null,
                   "addressStreet2": null,
                   "addressCity": null,
                   "addressPostcode": null,
                   "addressState": null,
                   "addressCountry": null,
                   "addressLat": null,
                   "addressLng": null
               },
               "createdBy": {
                   "source": "MANUAL",
                   "workspaceMemberId": null,
                   "name": ""
               },
               "people": [],
               "activityTargets": [],
               "taskTargets": [],
               "noteTargets": [],
               "opportunities": [],
               "favorites": [],
               "attachments": [],
               "timelineActivities": [],
               "introVideo": {
                   "primaryLinkLabel": "",
                   "primaryLinkUrl": "",
                   "secondaryLinks": null
               }
           },

While I'm trying to find such person, REST API returns empty record meaning this person does not exist.

[FelixMalfait]

I'm not yet convinced there's really an issue here? As long as createBy is nullable (because of historical data), it can make sense to keep a null createdBy in the seeds imo

[BOHEUS]

Okay, then what about the case where someone creates new Opportunity object but later they changed their job and their account was deleted? What's the business logic flow for it? I imagine that's the result of it (missing data in createdBy) and it should be fixed.

[BOHEUS]

I found something weird, in Twenty workspace Opportunities with Jony Ive don't have data in Created by column but in Apple workspace, Opportunities have normal visible data

Twenty workspace

Apple workspace

Edit: that's because user Jony Ive exists in Apple workspace but not in Twenty workspace, so Twenty workspace, while it has correct data, can't return it due to missing record in database.

[FelixMalfait]

Edit: that's because user Jony Ive exists in Apple workspace but not in Twenty workspace, so Twenty workspace, while it has correct data, can't return it due to missing record in database.

Ah yes good catch, that should be an easy fix in the seeds! You can replace in typeorm-seeds/workspace/opportunities.ts, DEV_SEED_WORKSPACE_MEMBER_IDS.JONY by DEV_SEED_WORKSPACE_MEMBER_IDS.TIM which belongs to both workspace. You want to raise the PR for it 😁? Thanks

[BOHEUS]

Sure, I'll create a PR.

[BOHEUS]

@FelixMalfait I have scenario to reproduce this bug, while my changes fixed the problem with "wrong" data, it still exists (the business logic flow I wrote earlier)

Scenario:

1. Log in
2. Go to Settings > Members
3. Copy invite link
4. Open new browser and paste the copy link
5. Create an account
6. Create new People, Company or Opportunity object (Actual: newly created member isn't visible in Created by field)
7. Refresh page (now it's visible)
8. Go back to browser from step 1
9. Go to Settings > Members and delete member created in step 5
10. Refresh page and check object(s) from step 6

Actual: Created by field has missing data
Expected: Created by field should have data of deleted member (API response from earlier shows that object has stored creator's first and last name), after clicking on this member it shouldn't redirect to it's page as member object doesn't exist in database so link for its' profile can't be generated (to be decided by @CoreTeamTwenty)