Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if relation before trying to input relation label #7605

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Oct 11, 2024

Bug introduced by #7363
Input value was not set during edition for field that were not relations

Fixed
Capture d’écran 2024-10-11 à 16 53 56

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses a bug in the field editing functionality for non-relation fields in the data model settings.

  • Added a condition in SettingsDataModelFieldIconLabelForm.tsx to check for relationType before updating the label
  • Prevents unnecessary label updates for non-relation fields during editing
  • Fixes an issue introduced by a previous pull request (Prefill Relation Fields with Initiating Object Icon and Name #7363)
  • Ensures correct input value setting for fields that are not relations
  • Improves the user experience when editing various field types in the data model settings

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@thomtrp thomtrp merged commit c91a8c6 into main Oct 11, 2024
13 checks passed
@thomtrp thomtrp deleted the tt-fix-input-value-edition branch October 11, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants