Prefill Relation Fields with Initiating Object Icon and Name #7363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request implements the desired behavior for prefilling relation fields with the initiating object's icon and name. Here's a concise summary of the changes:
- Added logic to automatically update the relation field name based on the selected relation type
- Implemented prefilling of the initiating object's icon for the relation field
- Introduced a mechanism to prevent automatic updates if the user manually edits the field name
- Modified the
useRelationSettingsFormInitialValueshook to use appropriate labels (plural or singular) based on the relation type - Updated the
SettingsDataModelFieldRelationSettingsFormCardcomponent to pass theobjectMetadataItemprop, enabling access to the initiating object's information
These changes significantly improve the user experience when creating relations between objects by providing intelligent defaults and reducing manual input.
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+51
to
57
| label: [ | ||
| RelationDefinitionType.ManyToMany, | ||
| RelationDefinitionType.ManyToOne, | ||
| ].includes(initialRelationType) | ||
| ? initialRelationObjectMetadataItem.labelPlural | ||
| : initialRelationObjectMetadataItem.labelSingular, | ||
| }, |
There was a problem hiding this comment.
style: Consider extracting this logic into a separate function for better readability and maintainability
|
|
|
@sid0-0 Very nice work, thank you for the video it's well appreciated by the reviewer ;) |
lucasbordeau
approved these changes
Oct 10, 2024
ehconitin
added a commit
to ehconitin/twenty
that referenced
this pull request
Oct 11, 2024
…wentyhq#7363)" This reverts commit e45e45d.
Merged
thomtrp
added a commit
that referenced
this pull request
Oct 11, 2024
Bug introduced by #7363 Input value was not set during edition for field that were not relations Fixed <img width="893" alt="Capture d’écran 2024-10-11 à 16 53 56" src="https://github.com/user-attachments/assets/511077c6-5dff-49a1-b058-24a83d998dcf">
lucasbordeau
added a commit
that referenced
this pull request
Oct 11, 2024
@lucasbordeau forms are broken! revert - #7363 used useRelationSettingsFormInitialValues hook from that commit. TODO - figure out a way to change the relation name label from singular to plural and vice versa, until it is edited. related issue - #7355 --------- Co-authored-by: Lucas Bordeau <[email protected]>
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
…q#7363) feat: twentyhq#7355 Behaviour implemented: 1. Relation field name field is updated when relation type is updated 2. Icon is only prefilled in the beginning 3. If user manually edits the field name, then no subsequent updates are made to that field upon relation type change. https://github.com/user-attachments/assets/d372b106-8dcb-458d-8374-a76cd130f091 --------- Co-authored-by: sid0-0 <[email protected]> Co-authored-by: Lucas Bordeau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: #7355
Behaviour implemented:
Screen.Recording.2024-10-01.at.1.45.21.AM.mp4