fix: right drawer top bar story, adding some decorator and state setter #7580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request updates the Storybook story for the RightDrawerTopBar component, addressing issues and improving its functionality.
- Renamed story title from 'RightDrawerActivityTopBar' to 'RightDrawerTopBar' in
packages/twenty-front/src/modules/ui/layout/right-drawer/components/__stories__/RightDrawerTopBar.stories.tsx - Added
ComponentWithRouterDecoratorandRecoilDecoratorto enhance story context - Implemented
useEffectto set initial states for isRightDrawerOpen and currentRightDrawerPage - Introduced a
playfunction for automated interaction testing in Storybook
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Awarding rizdarmwn: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/rizdarmwn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #7496
Changed the title to
RightDrawerTopBarinstead ofRightDrawerActivityTopBar, following the component name.Add some missing decorator, and add state setter effect.
Screenshot
Missing coverages screenshot.