Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storybook Testing] Fix RightDrawerActivityTopBar story #7496

Closed
Tracked by #7491
charlesBochet opened this issue Oct 8, 2024 · 17 comments · Fixed by #7580
Closed
Tracked by #7491

[Storybook Testing] Fix RightDrawerActivityTopBar story #7496

charlesBochet opened this issue Oct 8, 2024 · 17 comments · Fixed by #7580
Assignees
Labels
good first issue Good for newcomers

Comments

@charlesBochet
Copy link
Member

charlesBochet commented Oct 8, 2024

Context

This issue is part of a Storybook effort on the project. You will find more context and guidance in the main issue: #7491

What

Fix the following existing story: /story/modules-activities-rightdrawer-rightdraweractivitytopbar--default

image
@charlesBochet
Copy link
Member Author

/oss.gg 150

Copy link

oss-gg bot commented Oct 8, 2024

Thanks for opening an issue! It's live on oss.gg!

@naaa760
Copy link

naaa760 commented Oct 8, 2024

/assign

@oss-gg oss-gg bot assigned naaa760 Oct 8, 2024
Copy link

oss-gg bot commented Oct 8, 2024

Assigned to @naaa760! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@rizdarmwn
Copy link
Contributor

/assign

Copy link

oss-gg bot commented Oct 9, 2024

Assigned to @rizdarmwn! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

Copy link

oss-gg bot commented Oct 10, 2024

@naaa760, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@Shuklashashi0706
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@Kushalshakya
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@Kushalshakya
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@mrjayantbokade
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

charlesBochet pushed a commit that referenced this issue Oct 11, 2024
…er (#7580)

# Context
Fixes #7496 
Changed the title to `RightDrawerTopBar` instead of
`RightDrawerActivityTopBar`, following the component name.
Add some missing decorator, and add state setter effect.

# Screenshot

![image](https://github.com/user-attachments/assets/0c6ae774-4602-45ef-8b46-457b7c549ba0)

Missing coverages screenshot.
Copy link

oss-gg bot commented Oct 12, 2024

@naaa760, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

1 similar comment
Copy link

oss-gg bot commented Oct 14, 2024

@naaa760, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants