-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Settings Navigation drawer crops elements #7557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request addresses the issue of the Settings Navigation drawer cropping elements on mobile devices by adjusting the drawer's width.
- Modified
StyledContainer
inNavigationDrawer.tsx
to set mobile width to 95% instead of 100% - Adds a small margin on the right side of the drawer in mobile view to prevent element cropping
- Improves visibility of search icon and toggle containers on mobile devices
- Aligns with "Approach 2" from the related issue, providing a more balanced layout
- Maintains consistency with desktop view while enhancing mobile user experience
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
@harshit078 Thanks for the PR! Modifying the width to an arbitrary value such as 95% does not seem to be right. We should get back to what we are trying to achieve and make the CSS match it. Here if we want to add more padding on the left, we should add more padding on the left :) |
Okay, I'll adjust the padding and revert the changes |
Log
|
Closes twentyhq#7550 --------- Co-authored-by: Lucas Bordeau <[email protected]>
Closes twentyhq#7550 --------- Co-authored-by: Lucas Bordeau <[email protected]>
Closes #7550