Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings Navigation drawer crops elements #7550

Closed
harshit078 opened this issue Oct 10, 2024 · 2 comments · Fixed by #7557
Closed

Settings Navigation drawer crops elements #7550

harshit078 opened this issue Oct 10, 2024 · 2 comments · Fixed by #7557

Comments

@harshit078
Copy link
Contributor

Bug Description

  • The current navigation drawer clips the search icon and Toggle containers as they are not shown in mobile viewport.
  • In mobile, the navigation drawer feels too close to left margin and a little bit of spacing would be ideal

Current Behaviour

Screenshot 2024-10-10 at 11 38 03 AM

Expected behavior

  • Approach 1.
Screenshot 2024-10-10 at 11 43 14 AM

  • in the traditional approach, the column looks too far from the left border

  • Approach 2.

Screenshot 2024-10-10 at 11 51 38 AM
Screen.Recording.2024-10-10.at.11.49.07.AM.mov

Along with animation, this approach could be improvised.
@harshit078
Copy link
Contributor Author

@Bonapara, whats your take on this ?

@Bonapara
Copy link
Member

Approach 1 looks great! Thanks @harshit078

@harshit078 harshit078 mentioned this issue Oct 10, 2024
Merged
lucasbordeau added a commit that referenced this issue Oct 10, 2024
@harshit078 @lucasbordeau
fix: Settings Navigation drawer crops elements (#7557)
9277cb7 
Closes #7550

---------

Co-authored-by: Lucas Bordeau <[email protected]>
harshit078 added a commit to harshit078/twenty that referenced this issue Oct 14, 2024
@harshit078 @lucasbordeau
fix: Settings Navigation drawer crops elements (twentyhq#7557)
c8ce9bc 
Closes twentyhq#7550

---------

Co-authored-by: Lucas Bordeau <[email protected]>
harshit078 added a commit to harshit078/twenty that referenced this issue Nov 7, 2024
@harshit078 @lucasbordeau
fix: Settings Navigation drawer crops elements (twentyhq#7557)
3dd1866 
Closes twentyhq#7550

---------

Co-authored-by: Lucas Bordeau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Settings Navigation drawer crops elements harshit078/twenty
2 participants
@Bonapara @harshit078