Make workflow objects read only in frontend #7545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomtrp the CI is red because of the linter! |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces changes to make workflow objects read-only in the frontend, implementing new utility functions and modifying existing components to enforce read-only behavior for specific workflow-related objects.
- Added
isWorkflowSubObjectutility function inisWorkflowSubObject.tsto identify WorkflowVersion and WorkflowRun objects - Replaced
isRemoteObjectwithisReadOnlyObjectinuseRecordActionBar.tsxto determine read-only status for records - Implemented
isFieldReadonlyFromObjectMetadataNameinuseIsFieldReadOnly.tsto control field editability based on object metadata - Modified
RecordIndexPageHeader.tsxandRecordTableEmptyStateDisplay.tsxto conditionally render add buttons for non-read-only objects - Updated
WorkflowWorkspaceEntityin the backend to cascade delete related entities when a workflow is deleted
12 file(s) reviewed, 11 comment(s)
Edit PR Review Bot Settings
packages/twenty-front/src/modules/object-metadata/hooks/useObjectIsRemote.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-metadata/utils/isWorkflowSubObject.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/record-field/hooks/useIsFieldReadOnly.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/record-field/hooks/useIsFieldReadOnly.ts
Outdated
Show resolved
Hide resolved
...ges/twenty-front/src/modules/object-record/record-index/components/RecordIndexPageHeader.tsx
Outdated
Show resolved
Hide resolved
...-record/record-show/record-detail-section/components/RecordDetailRelationRecordsListItem.tsx
Outdated
Show resolved
Hide resolved
...s/object-record/record-show/record-detail-section/components/RecordDetailRelationSection.tsx
Outdated
Show resolved
Hide resolved
...s/object-record/record-show/record-detail-section/components/RecordDetailRelationSection.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageMoreButton.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageMoreButton.tsx
Outdated
Show resolved
Hide resolved
thomtrp
force-pushed
the
tt-set-workflows-as-read-only-on-frontend
branch
from
1c7bcf6
to
402228d
Compare
@charlesBochet CI is fixed |
You bet :D |
thomtrp
force-pushed
the
tt-set-workflows-as-read-only-on-frontend
branch
from
98133c4
to
e9bb2d0
Compare
For good this time 😂 |
packages/twenty-front/src/modules/object-metadata/utils/isReadOnlyObject.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-metadata/utils/isWorkflowSubObject.ts
Outdated
Show resolved
Hide resolved
| return ( | ||
| fieldDefinition.metadata.fieldName === 'noteTargets' || | ||
| fieldDefinition.metadata.fieldName === 'taskTargets' || | ||
| metadata.fieldName === 'noteTargets' || |
...-front/src/modules/object-record/record-field/utils/isFieldReadonlyFromObjectMetadataName.ts
Outdated
Show resolved
Hide resolved
charlesBochet
approved these changes
Oct 10, 2024
thomtrp
force-pushed
the
tt-set-workflows-as-read-only-on-frontend
branch
from
1a56bfc
to
87f665a
Compare
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Expected behavior: - workflows can be added and deleted. Only name field is editable - versions and runs cannot be added nor deleted. No fields are editable Added two new utils for those needs: - `isReadOnlyObject` the similar logic between remote objects, versions and runs - `isFieldReadonlyFromObjectMetadataName` to easily block field edition from object context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior:
Added two new utils for those needs:
isReadOnlyObjectthe similar logic between remote objects, versions and runsisFieldReadonlyFromObjectMetadataNameto easily block field edition from object context