Remove unused call + rename var

twentyhq · Oct 9, 2024 · 402228d · 402228d
1 parent 4afafaf
commit 402228d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 11 deletions.
diff --git a/packages/twenty-front/src/modules/object-record/record-field/hooks/useIsFieldReadOnly.ts b/packages/twenty-front/src/modules/object-record/record-field/hooks/useIsFieldReadOnly.ts
@@ -8,11 +8,11 @@ import { FieldContext } from '../contexts/FieldContext';
 export const useIsFieldReadOnly = () => {
   const { fieldDefinition } = useContext(FieldContext);
 
-  const metadata = fieldDefinition.metadata;
+  const { metadata } = fieldDefinition;
 
   return (
-    fieldDefinition.metadata.fieldName === 'noteTargets' ||
-    fieldDefinition.metadata.fieldName === 'taskTargets' ||
+    metadata.fieldName === 'noteTargets' ||
+    metadata.fieldName === 'taskTargets' ||
     isFieldActor(fieldDefinition) ||
     isFieldRichText(fieldDefinition) ||
     isFieldReadonlyFromObjectMetadataName(

diff --git a/...cord/record-show/record-detail-section/components/RecordDetailRelationRecordsListItem.tsx b/...cord/record-show/record-detail-section/components/RecordDetailRelationRecordsListItem.tsx
@@ -181,7 +181,7 @@ export const RecordDetailRelationRecordsListItem = ({
     [isExpanded],
   );
 
-  const isReadOnly = !isFieldReadonlyFromObjectMetadataName(
+  const canEdit = !isFieldReadonlyFromObjectMetadataName(
     fieldDefinition.metadata.fieldName,
     fieldDefinition.metadata.objectMetadataNameSingular,
   );
@@ -201,7 +201,7 @@ export const RecordDetailRelationRecordsListItem = ({
             accent="tertiary"
           />
         </StyledClickableZone>
-        {isReadOnly && (
+        {canEdit && (
           <DropdownScope dropdownScopeId={dropdownScopeId}>
             <Dropdown
               dropdownId={dropdownScopeId}

diff --git a/...bject-record/record-show/record-detail-section/components/RecordDetailRelationSection.tsx b/...bject-record/record-show/record-detail-section/components/RecordDetailRelationSection.tsx
@@ -159,7 +159,7 @@ export const RecordDetailRelationSection = ({
       recordId,
     });
 
-  const isReadOnly = !isFieldReadonlyFromObjectMetadataName(
+  const canEdit = !isFieldReadonlyFromObjectMetadataName(
     fieldDefinition.metadata.fieldName,
     fieldDefinition.metadata.objectMetadataNameSingular,
   );
@@ -184,7 +184,7 @@ export const RecordDetailRelationSection = ({
         hideRightAdornmentOnMouseLeave={!isDropdownOpen && !isMobile}
         areRecordsAvailable={relationRecords.length > 0}
         rightAdornment={
-          isReadOnly && (
+          canEdit && (
             <DropdownScope dropdownScopeId={dropdownId}>
               <StyledAddDropdown
                 dropdownId={dropdownId}

diff --git a/packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageMoreButton.tsx b/packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageMoreButton.tsx
@@ -11,7 +11,6 @@ import { useDropdown } from '@/ui/layout/dropdown/hooks/useDropdown';
 import { MenuItem } from '@/ui/navigation/menu-item/components/MenuItem';
 import { navigationMemorizedUrlState } from '@/ui/navigation/states/navigationMemorizedUrlState';
 
-import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';
 import { useDestroyManyRecords } from '@/object-record/hooks/useDestroyManyRecords';
 import { useRestoreManyRecords } from '@/object-record/hooks/useRestoreManyRecords';
 import { recordStoreFamilyState } from '@/object-record/record-store/states/recordStoreFamilyState';
@@ -42,9 +41,7 @@ export const ShowPageMoreButton = ({
   const { restoreManyRecords } = useRestoreManyRecords({
     objectNameSingular,
   });
-  const { objectMetadataItem } = useObjectMetadataItem({
-    objectNameSingular,
-  });
+
   const handleDelete = () => {
     deleteOneRecord(recordId);
     closeDropdown();