-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] - Trim Names in Settings > Members table #7509 #7525
[Fix] - Trim Names in Settings > Members table #7509 #7525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR implements text trimming for long names in the Settings > Members table, improving layout and readability.
- Added
StyledScrollableTextContainer
with max-width and ellipsis for name display - Implemented
AppTooltip
to show full names on hover - Adjusted
StyledTableCell
for better mobile responsiveness - Modified
TableRow
rendering to include new styling and tooltip functionality - Updated imports to include necessary components from 'twenty-ui'
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Hi @Karankhatik, thanks for the PR |
Hello @charlesBochet what should I do, should I work on @Bonapara feedback or code is fine. Please confirm. |
Work on @Bonapara feedbacks :) |
@Bonapara I've successfully removed the undesired space; however, there's an issue where, if the name is shorter then the (ellipsis length), the email gets too close to the name, which affects the layout. Please provide your suggestions. |
@Karankhatik The issue isn't the spacing between the fields, which should remain the same. It's the name field that isn't using its full available width. The spacing between the fields should remain 16px |
You also have conflicts now :) |
@Bonapara, you mean the text should take up the entire width of the container, and only when it exceeds the container's width, we apply an ellipsis? Also, the space between the name and email will be 16px. Is that correct? |
Absolutely! |
Thanks will update u. |
…max-width for responsiveness and ensure 16px spacing.
…b.com/Karankhatik/twenty into fix/trim-names-settings-members-table
@@ -97,6 +103,26 @@ const StyledTableHeaderRow = styled(Table)` | |||
margin-bottom: ${({ theme }) => theme.spacing(1.5)}; | |||
`; | |||
|
|||
const StyledTableRowForMemberList = styled(TableRow)` | |||
gap: 16px; | |||
@media (max-width: 768px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all these cases look too heavy, I'm taking a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reworked a bit to simplify CSS
Issue: Long names in the Members table were overflowing, affecting the layout.
Fix: