Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim Names in Settings > Members table #7509

Closed
Bonapara opened this issue Oct 8, 2024 · 7 comments
Closed

Trim Names in Settings > Members table #7509

Bonapara opened this issue Oct 8, 2024 · 7 comments
Assignees
@Karankhatik
Labels
good first issue Good for newcomers prio: low scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@Bonapara
Copy link
Member

Bonapara commented Oct 8, 2024 •
edited
Loading

Desired behavior

Long values should be trimmed with ellipses in the Settings/Members table.

28cf3be7396f37107a861ae99655972982f93cb675012575c575e26fa05b110e
@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement prio: low labels Oct 8, 2024
@Karankhatik
Copy link
Contributor

Please assign this issue to me.

@Bonapara
Copy link
Member Author

Bonapara commented Oct 8, 2024

Sure @Karankhatik, thanks for contributing!

Karankhatik pushed a commit to Karankhatik/twenty that referenced this issue Oct 9, 2024
Fix: Trim long names in Settings > Members table with ellipses and ad…
bdf5311 
…d tooltips (twentyhq#7509).
@SyedHamzaHussain000
Copy link
Contributor

/assign

@SyedHamzaHussain000
Copy link
Contributor

\assign

1 similar comment
@AnubhavSingh99
Copy link

\assign

charlesBochet added a commit that referenced this issue Oct 13, 2024
@Karankhatik @charlesBochet
[Fix] - Trim Names in Settings > Members table #7509 (#7525)
1e6346f 
Issue: Long names in the Members table were overflowing, affecting the
layout.

Fix:
- Trimmed long names with ellipses.
- Added tooltips to display the full content on hover.
- Max-width of the text dynamically set to 90px on large screens, and
60px on mobile.

![image](https://github.com/user-attachments/assets/3b5d1c08-fe0e-4c0b-952a-0fc0f9e513bc)

---------

Co-authored-by: karankhatik <[email protected]>
Co-authored-by: Charles Bochet <[email protected]>
@oss-gg oss-gg bot mentioned this issue Oct 16, 2024
Closed
@Karankhatik
Copy link
Contributor

@Bonapara can u please close this issue as this is merged successfully.

@Bonapara
Copy link
Member Author

Sure, thanks @Karankhatik

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Karankhatik Karankhatik

Labels
good first issue Good for newcomers prio: low scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Bonapara @AnubhavSingh99 @SyedHamzaHussain000 @Karankhatik