Fix focused cell view #7451
Fix focused cell view #7451
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request removes the use of createPortal in the RecordTableCellEditMode component to address issues with focused cell positioning and visibility during horizontal scrolling.
- Removed createPortal usage in
packages/twenty-front/src/modules/object-record/record-table/record-table-cell/components/RecordTableCellEditMode.tsx - StyledTableCellInput now renders directly within StyledEditableCellEditModeContainer
- Improves cell positioning and visibility behavior when scrolling horizontally
- Fixes overlap issues with other elements during scrolling
- Ensures proper hiding/unfocusing of cells when necessary
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
|
@charlesBochet Could you please review and let me know if there’s anything further needed from my side? |
|
@charlesBochet @lucasbordeau Could you please check? I still haven't received 150 points for this issue. |
|
@lucasbordeau Could you please check? I still haven't received 150 points for this issue. |
|
/award 150 |
|
Awarding AshishViradiya153: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/AshishViradiya153 |
Fixes twentyhq#5595 - The portal has been removed, and the focused cell is now rendered directly within the relevant div/container. - This ensures that the cell remains correctly positioned within the table and is properly hidden or unfocused when the user scrolls horizontally, fixing the issue of overlap or visibility on top of other elements. Co-authored-by: Lucas Bordeau <[email protected]>
Fixes #5595