Focused cell is acting weird when scrolling horizontally

[ijreilly]

Enregistrement.de.l.ecran.2024-05-27.a.13.41.31.mov

[greptile-apps]

Disclaimer: This comment was automatically generated with AI. It can give some useful hints as to where to look for, but sometimes it can also give very inaccurate answers so takes this with a pinch of salt :).

To address the issue of the focused cell acting weird when scrolling horizontally, follow these steps:

1. Locate the relevant component: The issue is likely within the table components handling activities. Check /packages/twenty-front/src/modules/activities/table/components/CellCommentChip.tsx and /packages/twenty-front/src/modules/activities/table/components/CommentChip.tsx.

2. Check the scrolling behavior: Ensure that the focused cell maintains its state and position correctly during horizontal scrolling. This might involve adjusting the CSS or the component's state management.

3. Adjust the context if necessary: Review the InlineCellMutationContext and useInlineCell hook in /packages/twenty-front/src/modules/object-record/record-inline-cell to ensure the focused cell's state is managed correctly during scroll events.

4. Modify the component: If needed, add or adjust event listeners for scroll events to maintain the focus state. Example:

useEffect(() => {
  const handleScroll = () => {
    // Logic to maintain focus state
  };
  window.addEventListener('scroll', handleScroll);
  return () => window.removeEventListener('scroll', handleScroll);
}, []);

5. Test the changes: Ensure the focused cell behaves correctly during horizontal scrolling.

References

/packages/twenty-front/src/modules/activities/table
/packages/twenty-front/src/modules/activities/table/components
/packages/twenty-front/src/modules/object-record/record-inline-cell

Ask Greptile

[its-id]

looking into it. let me see if this can be fixed.

[ijreilly]

• this could be linked - when selecting multiple rows they become transparent

Enregistrement.de.l.ecran.2024-06-05.a.12.23.02.mov

[Nabhag8848]

Working on it 🔥 - P0 priority.

• Issue with when selecting multiple rows looks like is been already resolved.

Edit: changing priority to P2, this is tricky then i thought, just z-index won't fix this i believe.

also Question: Also later we will have a behaviour that when cell is focused, table shouldn't be scrollable (left and right) ideally this is what I think behaviour is, tackling both makes at the same time makes more sense to me.

[charlesBochet]

Duplicated issue: #6813, let's make sure both are fixed

[charlesBochet]

The issue is still there!

[Bonapara]

/oss.gg 150

[oss-gg]

Thanks for opening an issue! It's live on oss.gg!

[kshitij-codes]

/assign

[oss-gg]

Assigned to @kshitij-codes! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[AshishViradiya153]

/assign

[oss-gg]

Assigned to @AshishViradiya153! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[mokshith-moksh]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.