Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7417 workflows i can send emails using the email account #7431
7417 workflows i can send emails using the email account #7431
Changes from 15 commits
05fc02c
2ad87b4
b186b09
4971a2e
b7a397a
fd46298
5bfb2ff
6693f2c
9aa36f5
2a0829e
fdde163
8488c7b
52e0b54
6619cb8
4697bb0
0c1d0c8
f053d52
7c2cc7e
abdbd52
80e0d4a
00fb346
33b2989
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely convinced we should add specific use cases to the raw Select components. The Select component should allow composition: We should be able to add such a button quickly, but the Select component should not know about it.
One example I like is Headless UI components:
Another solution, if we want to add buttons in selects often, is to make it possible to inject buttons through the
options
property:If we keep adding specific use cases like this to the Select component itself, it will quickly become bloated.
I don't think we should change something to your PR, this is more a discussion to start with the whole team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I Allowed that to myself as there already is a
SearchInput
option that can be displayed at the bottom of the select. @charlesBochet @thomtrp wdyt?