7417 workflows i can send emails using the email account #7431

martmull · 2024-10-04T14:43:30Z

update send-email.workflow-action.ts so it send email via the google sdk
remove useless workflow-action.email.ts
add send authorization to google api scopes
update the front workflow email step form to provide a connectedAccountId from the available connected accounts
update the permissions of connected accounts: ask users to reconnect when selecting missing send permission

charlesBochet · 2024-10-04T23:16:44Z

...nty-server/src/engine/core-modules/auth/strategies/google-apis-oauth-common.auth.strategy.ts

@@ -23,6 +23,7 @@ export class GoogleAPIsOauthCommonStrategy extends PassportStrategy(
      'email',
      'profile',
      'https://www.googleapis.com/auth/gmail.readonly',
+      'https://www.googleapis.com/auth/gmail.send',


we will need to put that behind a feature flag as we will need to go through the google approval process and it can take up to a month. We will be able to test with a short list of accounts in the meantime and will need the flag :)

Also it's likely that we will need to have a process to ask users to reconnect their account if we detect that the scope is missing (maybe when we try to send an email and get a 403 the first time) We already have similar mechanism for messaging sync

…Member

greptile-apps

PR Summary

This pull request implements email sending functionality using connected Google accounts in the Twenty application's workflow system. Here's a concise summary of the major changes:

Implemented email sending via Google SDK in send-email.workflow-action.ts
Added 'https://www.googleapis.com/auth/gmail.send' scope to Google API OAuth scopes
Updated WorkflowEditActionFormSendEmail component to select connected accounts for email sending
Added 'scopes' field to ConnectedAccountWorkspaceEntity and related repository methods
Introduced MailSenderException for handling mail sender-related errors
Updated WorkflowSendEmailStepSettings to use connectedAccountId instead of template-based approach

_{21 file(s) reviewed, 8 comment(s)}
_{Edit PR Review Bot Settings}

packages/twenty-front/src/modules/accounts/constants/GmailSendScope.ts

packages/twenty-front/src/modules/workflow/components/WorkflowEditActionFormSendEmail.tsx

packages/twenty-front/src/modules/workflow/types/Workflow.ts

...nty-server/src/engine/core-modules/auth/strategies/google-apis-oauth-common.auth.strategy.ts

packages/twenty-server/src/modules/mail-sender/exceptions/mail-sender.exception.ts

packages/twenty-server/src/modules/mail-sender/workflow-actions/send-email.workflow-action.ts

…mail-account

thomtrp · 2024-10-08T13:57:32Z

packages/twenty-front/src/modules/workflow/components/WorkflowEditActionFormSendEmail.tsx

+        eq: action.settings.connectedAccountId,
+      },
+    });
+  }


could we extract this logic, as long as the select component? I feel this kind of app connection will happen often. It should be re-usable and not specific to SendEmailAction. Wdyt?

Think we should wait for the next action to be implemented to factorize this logic

packages/twenty-server/src/modules/mail-sender/workflow-actions/send-email.workflow-action.ts

Devessier

Great job! I left a few comments for things I think we should discuss 😄

Devessier · 2024-10-08T14:01:29Z

packages/twenty-front/src/modules/ui/input/components/Select.tsx

@@ -32,6 +39,7 @@ export type SelectProps<Value extends string | number | null> = {
  options: SelectOption<Value>[];
  value?: Value;
  withSearchInput?: boolean;
+  callToActionButton?: CallToActionButton;


I'm not entirely convinced we should add specific use cases to the raw Select components. The Select component should allow composition: We should be able to add such a button quickly, but the Select component should not know about it.

One example I like is Headless UI components:

Another solution, if we want to add buttons in selects often, is to make it possible to inject buttons through the options property:

options={[{ label: 'XX', value: "" }, { type: "divider" }, { type: "button", label: "Add one +", onClick: () => {}, icon: "" }]}

If we keep adding specific use cases like this to the Select component itself, it will quickly become bloated.

I don't think we should change something to your PR, this is more a discussion to start with the whole team.

I Allowed that to myself as there already is a SearchInput option that can be displayed at the bottom of the select. @charlesBochet @thomtrp wdyt?

Devessier · 2024-10-08T14:06:12Z

packages/twenty-front/src/modules/workflow/components/WorkflowEditActionFormSendEmail.tsx

+                onChange={(connectedAccountId) => {
+                  field.onChange(connectedAccountId);
+                  handleSave();
+                  checkConnectedAccountScopes(connectedAccountId);


What does happen if the user closes the Google tab we opened before completing the process? The account will be wired to the step – handleSave() is called before checkConnectedAccountScopes() – but the account wouldn't be set up correctly. Is it possible to recover from this error in the app currently?

you are right. In fact I call handleSave() before because we don't have access to the handleSave() method after the google oAuth, so it is not possible to do it.
In fact it is possible, but it would be a lot of work for something "temporary" as the accounts will have the proper scopes after they have been updated
Also, I think this oAuth triggered at dropdown select is a little bit aggressive, a warning banner would be better in my opinion, will discuss that with @Bonapara

packages/twenty-server/src/modules/mail-sender/workflow-actions/send-email.workflow-action.ts

…mail-account

- update `send-email.workflow-action.ts` so it send email via the google sdk - remove useless `workflow-action.email.ts` - add `send` authorization to google api scopes - update the front workflow email step form to provide a `connectedAccountId` from the available connected accounts - update the permissions of connected accounts: ask users to reconnect when selecting missing send permission ![image](https://github.com/user-attachments/assets/fe3c329d-fd67-4d0d-8450-099c35933645)

martmull added 3 commits October 4, 2024 15:10

Ask for gmail provider in send-email action

05fc02c

Update gmail sdk scopes

2ad87b4

Remove useless email

b186b09

martmull linked an issue Oct 4, 2024 that may be closed by this pull request

[Workflows] I can send emails using the email account #7417

Closed

charlesBochet added the -PR: wip label Oct 4, 2024

charlesBochet reviewed Oct 4, 2024

View reviewed changes

charlesBochet assigned martmull Oct 4, 2024

charlesBochet added the -PR: awaiting author label Oct 4, 2024

martmull added 3 commits October 7, 2024 11:12

Add select connectedAccountId

4971a2e

Update email action settings

b7a397a

Handle case when connectedAccount does not belong to currentWorkspace…

fd46298

…Member

martmull force-pushed the 7417-workflows-i-can-send-emails-using-the-email-account branch 3 times, most recently from e5101a4 to 0409f15 Compare October 7, 2024 13:58

WIP: add 'Add account' button

5bfb2ff

martmull force-pushed the 7417-workflows-i-can-send-emails-using-the-email-account branch from 0409f15 to 5bfb2ff Compare October 7, 2024 14:00

martmull added 2 commits October 7, 2024 17:59

Add scopes to connected account workspace entity

6693f2c

Wip: store scopes in connected accounts

9aa36f5

martmull force-pushed the 7417-workflows-i-can-send-emails-using-the-email-account branch 3 times, most recently from 5b3428b to 3b76753 Compare October 8, 2024 08:10

Use scopes in workflow page

2a0829e

martmull force-pushed the 7417-workflows-i-can-send-emails-using-the-email-account branch from 3b76753 to 2a0829e Compare October 8, 2024 08:47

martmull added 3 commits October 8, 2024 11:32

Fix issue

fdde163

Refactor

8488c7b

Fix lint

52e0b54

martmull marked this pull request as ready for review October 8, 2024 10:02

greptile-apps bot reviewed Oct 8, 2024

View reviewed changes

Devessier self-requested a review October 8, 2024 12:25

Greptile review

6619cb8

martmull added 2 commits October 8, 2024 15:18

Add log for email sent

4697bb0

Merge branch 'main' into 7417-workflows-i-can-send-emails-using-the-e…

0c1d0c8

…mail-account

thomtrp reviewed Oct 8, 2024

View reviewed changes

Devessier approved these changes Oct 8, 2024

View reviewed changes

martmull added 4 commits October 8, 2024 16:43

Add feature flag for gmail scopes

f053d52

Add specific exception when connected account not found

7c2cc7e

Fix check schopes

abdbd52

Merge branch 'main' into 7417-workflows-i-can-send-emails-using-the-e…

80e0d4a

…mail-account

martmull force-pushed the 7417-workflows-i-can-send-emails-using-the-email-account branch from 82b9586 to 80e0d4a Compare October 8, 2024 15:43

martmull added 2 commits October 8, 2024 18:18

Add loginHint when asking for new scopes

00fb346

Merge branch 'main' into 7417-workflows-i-can-send-emails-using-the-e…

33b2989

…mail-account

martmull merged commit f138a1c into main Oct 8, 2024
13 of 15 checks passed

martmull deleted the 7417-workflows-i-can-send-emails-using-the-email-account branch October 8, 2024 21:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7417 workflows i can send emails using the email account #7431

7417 workflows i can send emails using the email account #7431

martmull commented Oct 4, 2024 •

edited

Loading

charlesBochet Oct 4, 2024

greptile-apps bot left a comment

thomtrp Oct 8, 2024

martmull Oct 8, 2024

Devessier left a comment

Devessier Oct 8, 2024

martmull Oct 8, 2024

Devessier Oct 8, 2024

martmull Oct 8, 2024

7417 workflows i can send emails using the email account #7431

7417 workflows i can send emails using the email account #7431

Conversation

martmull commented Oct 4, 2024 • edited Loading

charlesBochet Oct 4, 2024

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

thomtrp Oct 8, 2024

Choose a reason for hiding this comment

martmull Oct 8, 2024

Choose a reason for hiding this comment

Devessier left a comment

Choose a reason for hiding this comment

Devessier Oct 8, 2024

Choose a reason for hiding this comment

martmull Oct 8, 2024

Choose a reason for hiding this comment

Devessier Oct 8, 2024

Choose a reason for hiding this comment

martmull Oct 8, 2024

Choose a reason for hiding this comment

martmull commented Oct 4, 2024 •

edited

Loading