fix #7085 breadcrumb fix for mobile viewport #7419
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses the issue of header overflow in the Data Model settings for mobile viewports. The changes focus on improving the Breadcrumb component for better mobile navigation.
- Modified
Breadcrumb.tsxto provide a simplified mobile-specific rendering with a back button - Added
PagesRedirectToApp.tsto define pages that should redirect to the main app on mobile - Implemented conditional rendering in
Breadcrumb.tsxbased on device type (mobile or desktop) - Enhanced mobile UX by showing either "Back to App" or "Back to [previous page]" for easier navigation
- Utilized
useIsMobilehook to determine the device type and adjust the breadcrumb display accordingly
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| currentPage as string, | ||
| ); |
There was a problem hiding this comment.
logic: Casting 'currentPage' to string may cause runtime errors if it's a ReactNode. Consider using a type guard instead.
| </StyledLink> | ||
| </Fragment> | ||
| ) : ( | ||
| <StyledText title={''}>{previousLink?.children}</StyledText> |
There was a problem hiding this comment.
style: Empty title attribute here. Consider removing it or providing a meaningful title.
|
@Bonapara Could you provide a more detailed explanation of the flow on mobile, because right now it seems odd |
|
The idea is to have a "Back button" that returns to the previous step. What seemed odd during testing? |
|
For me it seems like "Back to XYZ" isn't relevant here as we would want to just go back to the settings menu. We would like to have the same effect as when clicking on the cog. |
|
Let's do that @lucasbordeau, great idea! |
|
@lucasbordeau let's merge this one tomorrow! |
|
/award 150 |
|
Awarding NitinPSingh: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/NitinPSingh |
ISSUE
Closes #7085
DEMO
03.10.2024_20.15.32_REC.mp4