Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header overflows in Data model for mobile viewport #7085

Closed
harshit078 opened this issue Sep 17, 2024 · 26 comments · Fixed by #7419
Closed

Header overflows in Data model for mobile viewport #7085

harshit078 opened this issue Sep 17, 2024 · 26 comments · Fixed by #7419
Assignees
Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short

Comments

@harshit078
Copy link
Contributor

Bug Description

  • Go to Settings/Data Model
  • Add field and use it on mobile viewports
  • Since header has Type and configure properties, it makes the buttons component overflow

Current Behaviour

Screenshot 2024-09-17 at 11 55 28 AM Screenshot 2024-09-17 at 12 09 22 PM

Expected behavior

Screenshot 2024-09-17 at 11 56 43 AM

Approach

  • New field has a lot of unused spacing and padding. Removing that spacing could yield more header room
  • Instead of New field and then type, we can directly give type dropdown and remove New fiedl altogether which would give a clean look.
Screenshot 2024-09-17 at 12 08 41 PM
@Bonapara
Copy link
Member

I think we should introduce a mobile version of the breadcrumb - Will provide a design

@Bonapara Bonapara added the blocked: design needed This doesn't seem right label Sep 17, 2024
@Bonapara
Copy link
Member

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=40192-452783&node-type=frame&t=IXWRE0LasgigcLyR-11

image

We should display a back button with back to previous step name as label

@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short prio: med and removed blocked: design needed This doesn't seem right labels Sep 18, 2024
@Bonapara
Copy link
Member

Bonapara commented Oct 1, 2024

/oss.gg 150

Copy link

oss-gg bot commented Oct 1, 2024

Thanks for opening an issue! It's live on oss.gg!

@NitinPSingh
Copy link
Contributor

NitinPSingh commented Oct 2, 2024

hi @Bonapara ,
i am working on the issue , want to know what would be the back button for the general screen , as workspace redirect to /general
Screenshot 2024-10-02 142800

Screenshot 2024-10-02 142533-2

@Bonapara
Copy link
Member

Bonapara commented Oct 2, 2024

< Back to App that would close the settings would be cool @NitinPSingh. WDYT?

@NitinPSingh
Copy link
Contributor

/assign

Copy link

oss-gg bot commented Oct 3, 2024

Assigned to @NitinPSingh! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@NitinPSingh
Copy link
Contributor

hi can anyone review the pr

@Bonapara
Copy link
Member

Bonapara commented Oct 8, 2024

The tech team is on it @NitinPSingh ;)

@xRiddin
Copy link

xRiddin commented Oct 11, 2024

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@NitinPSingh NitinPSingh removed their assignment Oct 17, 2024
@HSRAKTU
Copy link

HSRAKTU commented Oct 17, 2024

/assign

@oss-gg oss-gg bot assigned HSRAKTU Oct 17, 2024
Copy link

oss-gg bot commented Oct 17, 2024

Assigned to @HSRAKTU! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@HSRAKTU
Copy link

HSRAKTU commented Oct 17, 2024

/unassign

@oss-gg oss-gg bot unassigned HSRAKTU Oct 17, 2024
Copy link

oss-gg bot commented Oct 17, 2024

Issue unassigned.

@rajeev99
Copy link

/assign

Copy link

oss-gg bot commented Oct 17, 2024

Assigned to @rajeev99! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Ashutoshpadhi629
Copy link

/assign

Copy link

oss-gg bot commented Oct 19, 2024

This issue is already assigned to another person. Please find more issues here.

Copy link

oss-gg bot commented Oct 20, 2024

@HSRAKTU, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 20, 2024

@rajeev99, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@jinxsaber
Copy link

/assign

Copy link

oss-gg bot commented Oct 21, 2024

This issue is already assigned to another person. Please find more issues here.

@charlesBochet
Copy link
Member

/award 150

Copy link

oss-gg bot commented Oct 31, 2024

Awarding harshit078: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshit078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

9 participants