-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed button group spacing of dropdown button #7409
Conversation
Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request modifies the Button component to address the issue of the dropdown button being too large in button groups by reducing its horizontal padding.
- Changed padding in
Button.tsx
fromtheme.spacing(2)
totheme.spacing(1.5)
to reduce button width - Modification affects all button sizes, potentially impacting 'Height Medium' buttons which should remain 32px wide
- No changes made to
ButtonGroup.tsx
or its stories, which may require adjustments for consistent styling - The fix doesn't differentiate between 'Height Small' and 'Height Medium' buttons as requested in the issue
- Consider adding size-specific padding logic to fully address the 24px vs 32px width requirement
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
@prakhar1535 that was fast! haha ;) |
@prakhar1535 , |
@ehconitin fixed the issue it does not interfare the core ui component. |
packages/twenty-front/src/modules/views/components/UpdateViewButtonGroup.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for contributing!
Thanks for corrections and merging :) |
twentyhq#7386 --------- Co-authored-by: Nitin Koche <[email protected]>
#7386