Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button group dropdown is too large #7386

Closed
Bonapara opened this issue Oct 2, 2024 · 8 comments
Closed

Button group dropdown is too large #7386

Bonapara opened this issue Oct 2, 2024 · 8 comments
Assignees
@prakhar1535
Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@Bonapara
Copy link
Member

Bonapara commented Oct 2, 2024 •
edited
Loading

Current behavior

The button dropdown is too wide (32px)

CleanShot 2024-10-02 at 11 14 33

Desired Behavior

Should be 24px x 24px for "Height Small" buttons and 32px (like today) for "Height Medium" buttons

d84bb65bc68d5e21892097bc6957d6c5fdd68db5e6d8272bc866ba1c775a6e9f
@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement prio: med labels Oct 2, 2024
@prakhar1535
Copy link
Contributor

prakhar1535 commented Oct 2, 2024 •
edited
Loading

may i work on this issue ? @Bonapara

@gaurimadan
Copy link

Hey, I would like to work on this issue. Assign me under Hacktoberfest 2024 @Bonapara

@Bonapara
Copy link
Member Author

Bonapara commented Oct 2, 2024

Sure @prakhar1535, thanks for contributing! Sorry @gaurimadan, @prakhar1535 was first ;)

@Bonapara
Copy link
Member Author

Bonapara commented Oct 2, 2024

/oss.gg 150

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 2, 2024

Thanks for opening an issue! It's live on oss.gg!

@prakhar1535 prakhar1535 mentioned this issue Oct 2, 2024
Closed
@prakhar1535
Copy link
Contributor

hey @Bonapara have a look #7393

@Bonapara
Copy link
Member Author

Bonapara commented Oct 2, 2024

Someone from tech team will review it shortly, thanks @prakhar1535!

@prakhar1535 prakhar1535 mentioned this issue Oct 2, 2024
Merged
ehconitin added a commit that referenced this issue Oct 2, 2024
@prakhar1535 @ehconitin
Fixed button group spacing of dropdown button (#7409)
b8e406c 
#7386

---------

Co-authored-by: Nitin Koche <[email protected]>
@ehconitin
Copy link
Contributor

closed in #7409

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Oct 2, 2024
harshit078 pushed a commit to harshit078/twenty that referenced this issue Oct 14, 2024
@prakhar1535 @ehconitin @harshit078
Fixed button group spacing of dropdown button (twentyhq#7409)
c1c8685 
twentyhq#7386

---------

Co-authored-by: Nitin Koche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prakhar1535 prakhar1535

Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Bonapara @prakhar1535 @gaurimadan @ehconitin