fix: Files field fix #7376
Merged
fix: Files field fix #7376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses issue #7324 by implementing the ability to save a renamed file when the user presses Enter in the file attachment section.
- Modified
packages/twenty-front/src/modules/activities/files/components/AttachmentRow.tsxto handle Enter key press for file renaming - Implemented logic to split file name and extension, preserving the extension during renaming
- Added functionality to save the renamed file on both Enter key press and clicking outside the input field
- Improved user experience in file management, specifically in the rename operation
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
63
to
69
| const getFileNameAndExtension = (filename: string) => { | ||
| const lastDotIndex = filename.lastIndexOf('.'); | ||
| return { | ||
| name: filename.substring(0, lastDotIndex), | ||
| extension: filename.substring(lastDotIndex), | ||
| }; | ||
| }; |
There was a problem hiding this comment.
style: Consider moving this function outside the component to improve performance
lucasbordeau
approved these changes
Oct 10, 2024
|
Nice work |
|
Thanks @harshit078 for your contribution! |
harshit078
added a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
## Description Closes twentyhq#7324 Closes twentyhq#7323 - This PR solves the issue - - twentyhq#7324 - twentyhq#7323 - On Enter the rename of the file is saved - Removed renaming of extension ## After Changes Behaviour https://github.com/user-attachments/assets/f5c47cd4-883e-473e-9cfa-e277f8f630c2 --------- Co-authored-by: Lucas Bordeau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #7324
Closes #7323
After Changes Behaviour
Screen.Recording.2024-10-02.at.2.33.16.AM.mov