Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming file shouldn't allow changing file extension #7323

Closed
BOHEUS opened this issue Sep 29, 2024 · 1 comment · Fixed by #7376
Closed

Renaming file shouldn't allow changing file extension #7323

BOHEUS opened this issue Sep 29, 2024 · 1 comment · Fixed by #7376
Assignees
@harshit078
Labels
for experienced contributor scope: front Issues that are affecting the frontend side only size: short

Comments

@BOHEUS
Copy link
Contributor

BOHEUS commented Sep 29, 2024

Scenario:

  1. Log in
  2. Go to People > record details > (doesn't matter which object as long as it has field with File type)
  3. Upload a file if there are no files
  4. Click on three vertical dots near date of upload and select "Rename" option
  5. Change extension of the file and save changes

Actual: After changing the file extension, file is saved properly but after downloading modified file, it's broken (which is expected as there was no conversion between old and new file format)
Screencast From 2024-09-29 21-53-31.webm

Expected: User must be able to change file's name but not the format/extension)
@harshit078
Copy link
Contributor

I'm working on this one also !

@Bonapara Bonapara added scope: front Issues that are affecting the frontend side only size: short for experienced contributor labels Sep 30, 2024
@harshit078 harshit078 mentioned this issue Oct 2, 2024
Merged
harshit078 added a commit to harshit078/twenty that referenced this issue Oct 14, 2024
@harshit078 @lucasbordeau
fix: Files field fix (twentyhq#7376)
5a367ef 
## Description

Closes twentyhq#7324 
Closes twentyhq#7323

- This PR solves the issue - 
- twentyhq#7324 
- twentyhq#7323
- On Enter the rename of the file is saved
- Removed renaming of extension

## After Changes Behaviour


https://github.com/user-attachments/assets/f5c47cd4-883e-473e-9cfa-e277f8f630c2

---------

Co-authored-by: Lucas Bordeau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshit078 harshit078

Labels
for experienced contributor scope: front Issues that are affecting the frontend side only size: short
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Files field fix harshit078/twenty
3 participants
@Bonapara @BOHEUS @harshit078