Changed condition on which 'Add task' button is displayed (#7333) #7362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request modifies the display logic for the 'Add task' button in the TaskGroups component, addressing issue #7333.
- Updated
TaskGroups.tsxto show 'Add task' button only for 'TODO' status or when no 'TODO' tasks exist - Removed unused
showAddButtonprop fromTaskGroupsandObjectTaskscomponents - Improved UI consistency by preventing 'Add task' button display in 'Done' section
- Simplified component logic by moving button display decision to
TaskGroups - Aligned implementation with desired behavior described in the issue
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
packages/twenty-front/src/modules/activities/tasks/components/TaskGroups.tsx
Outdated
Show resolved
Hide resolved
ehconitin
approved these changes
Oct 1, 2024
|
@FelixMalfait Thanks! :) |
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
) (twentyhq#7362) This PR addresses issue twentyhq#7333. It updates the condition for displaying the 'Add task' button. The button is now only visible for the 'TODO' section or when no 'TODO' block is present (i.e., there are no tasks in this category). Additionally, I removed the unused showAddButton, which is no longer necessary due to the updated logic.   --------- Co-authored-by: Nitin Koche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #7333. It updates the condition for displaying the 'Add task' button. The button is now only visible for the 'TODO' section or when no 'TODO' block is present (i.e., there are no tasks in this category).
Additionally, I removed the unused showAddButton, which is no longer necessary due to the updated logic.