Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Add task" button for Done tasks #7333

Closed
Bonapara opened this issue Sep 30, 2024 · 4 comments
Closed

Remove "Add task" button for Done tasks #7333

Bonapara opened this issue Sep 30, 2024 · 4 comments
Assignees
@lparz1val
Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@Bonapara
Copy link
Member

Current Behavior

On any record page Tasks tab, we display an "add task" button above the "Done" tasks section.

CleanShot 2024-09-30 at 13 30 03

Desired Behavior

Only the Todo section should have an "add task" button, as it doesn't make sense to create a done task.
@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement prio: med labels Sep 30, 2024
@lparz1val
Copy link
Contributor

Hey. I would like to help with this one!

@NinaVincova
Copy link

Hello. I would like to try to do my first issue on this task. Is it possible?

@Bonapara
Copy link
Member Author

Bonapara commented Sep 30, 2024 •
edited
Loading

Hi @NinaVincova, sorry @YuraL13 was first. You can have a look to our Good First Issues. Thank you both for contributing!

lparz1val added a commit to lparz1val/twenty that referenced this issue Sep 30, 2024
@lparz1val
Changed condition on which 'Add task' button is displayed (twentyhq#7333
a21512b 
)
@lparz1val lparz1val mentioned this issue Sep 30, 2024
Merged
FelixMalfait pushed a commit that referenced this issue Oct 2, 2024
@lparz1val @ehconitin
Changed condition on which 'Add task' button is displayed (#7333) (#7362
d7dd41e 
)

This PR addresses issue #7333. It updates the condition for displaying
the 'Add task' button. The button is now only visible for the 'TODO'
section or when no 'TODO' block is present (i.e., there are no tasks in
this category).
Additionally, I removed the unused showAddButton, which is no longer
necessary due to the updated logic.

![image](https://github.com/user-attachments/assets/571542d7-1b0f-4b91-afcf-4592490f1f72)

![image](https://github.com/user-attachments/assets/46974459-d3cd-497a-a6b6-9302cbff7716)

---------

Co-authored-by: Nitin Koche <[email protected]>
@ehconitin
Copy link
Contributor

closed in #7362

harshit078 pushed a commit to harshit078/twenty that referenced this issue Oct 14, 2024
@lparz1val @ehconitin @harshit078
Changed condition on which 'Add task' button is displayed (twentyhq#7333
2318fd6 
) (twentyhq#7362)

This PR addresses issue twentyhq#7333. It updates the condition for displaying
the 'Add task' button. The button is now only visible for the 'TODO'
section or when no 'TODO' block is present (i.e., there are no tasks in
this category).
Additionally, I removed the unused showAddButton, which is no longer
necessary due to the updated logic.

![image](https://github.com/user-attachments/assets/571542d7-1b0f-4b91-afcf-4592490f1f72)

![image](https://github.com/user-attachments/assets/46974459-d3cd-497a-a6b6-9302cbff7716)

---------

Co-authored-by: Nitin Koche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lparz1val lparz1val

Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Bonapara @NinaVincova @lparz1val @ehconitin