Add Header to Email & Calendar Tabs #7288 #7293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request adds a header to the Email and Calendar tabs when no account is connected, improving consistency across the settings interface.
- Added 'description' prop to SubMenuTopBarContainer in
packages/twenty-front/src/modules/ui/layout/page/SubMenuTopBarContainer.tsx - Updated title to "Connected Accounts" and added description "Manage your internet accounts" in
packages/twenty-front/src/pages/settings/accounts/SettingsAccountsEmails.tsx - SettingsAccountsCalendars.tsx should be updated to match the new style of the Email settings page for consistency
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -33,9 +34,18 @@ const StyledTitle = styled.h3` | |||
| margin: ${({ theme }) => theme.spacing(8, 8, 2)}; | |||
| `; | |||
|
|
|||
| const StyledDescription = styled.h3` | |||
There was a problem hiding this comment.
style: Consider using a more semantic HTML tag like 'p' instead of 'h3' for the description
This reverts commit 421bcd6.
|
Thanks @kant-github for your contribution! |
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
# Fix: 7288 - Add Header to Email & Calendar Tabs (No Account Connected) ## Description Added a header to the **Email** and **Calendar** tabs when no account is connected, matching the style and spacing of the account page to prevent layout issues when switching between pages. ### Header Content: - **Connected Accounts** - **Manage your internet accounts** ## Screenshot: <img width="1440" alt="Screenshot 2024-09-27 at 5 20 55 PM" src="https://github.com/user-attachments/assets/0c641dd6-e17f-47c4-9e30-45a3f8a9eac9"> Fixes twentyhq#7288 --------- Co-authored-by: Félix Malfait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: 7288 - Add Header to Email & Calendar Tabs (No Account Connected)
Description
Added a header to the Email and Calendar tabs when no account is connected, matching the style and spacing of the account page to prevent layout issues when switching between pages.
Header Content:
Screenshot:
Fixes #7288