Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Header to Email & Calendar Tabs #7288

Closed
Bonapara opened this issue Sep 27, 2024 · 2 comments · Fixed by #7293
Closed

Add Header to Email & Calendar Tabs #7288

Bonapara opened this issue Sep 27, 2024 · 2 comments · Fixed by #7293
Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@Bonapara
Copy link
Member

Bonapara commented Sep 27, 2024 •
edited
Loading

Current Behavior

Accounts Page

532ccb9f68e3fdbf19ad9dcc73c2cad46c6551c56b0de47a1f0b46ae6c175938

Email & Calendar Page

No section titles introduce the "No connected account" message.

CleanShot 2024-09-27 at 12 07 24

Desired Behavior

Add the following header to the Email & Calendar tabs when no account is connected. Ensure the spacing matches the account page to prevent content glitches when switching pages.

Connected Accounts
Manage your internet accounts

CleanShot 2024-09-27 at 12 08 14
@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement prio: med labels Sep 27, 2024
@kant-github
Copy link
Contributor

Hi @Bonapara , Can I solve this issue?

@Bonapara
Copy link
Member Author

Sure @kant-github, thanks for contributing!

kant-github added a commit to kant-github/twenty that referenced this issue Sep 27, 2024
@kant-github
fix: twentyhq#7288: Add Header to Email & Calendar Tabs
421bcd6
@FelixMalfait FelixMalfait mentioned this issue Sep 27, 2024
Merged
FelixMalfait added a commit to kant-github/twenty that referenced this issue Sep 27, 2024
@FelixMalfait
Revert "fix: twentyhq#7288: Add Header to Email & Calendar Tabs"
e3c9c8e 
This reverts commit 421bcd6.
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Sep 27, 2024
harshit078 pushed a commit to harshit078/twenty that referenced this issue Oct 14, 2024
@kant-github @FelixMalfait @harshit078
Add Header to Email & Calendar Tabs twentyhq#7288 (twentyhq#7293)
a322812 
# Fix: 7288 - Add Header to Email & Calendar Tabs (No Account Connected)

## Description
Added a header to the **Email** and **Calendar** tabs when no account is
connected, matching the style and spacing of the account page to prevent
layout issues when switching between pages.

### Header Content:
- **Connected Accounts**
- **Manage your internet accounts**

## Screenshot:
<img width="1440" alt="Screenshot 2024-09-27 at 5 20 55 PM"
src="https://github.com/user-attachments/assets/0c641dd6-e17f-47c4-9e30-45a3f8a9eac9">


Fixes twentyhq#7288

---------

Co-authored-by: Félix Malfait <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Header to Email & Calendar Tabs #7288 kant-github/twenty
2 participants
@Bonapara @kant-github