-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove useless hook call #7278
Merged
Merged
Remove useless hook call #7278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request removes unused hotkey-related code from the SettingsServerlessFunctionsTable component, addressing an issue with unintended navigation.
- Removed
useHotkeyScopeOnMount
hook and its import fromSettingsServerlessFunctionsTable.tsx
- Deleted
SettingsServerlessFunctionHotkeyScope
import, eliminating unnecessary code - Resolves issue Don't automatically redirect to the "New Function" page when pressing the "Enter" key on the "/settings/functions" page #7235 where pressing Enter redirected to the New function page in settings
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Weiko
approved these changes
Sep 30, 2024
Log
|
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Hook is no longer used after twentyhq#7236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hook is no longer used after #7236