-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't automatically redirect to the "New Function" page when pressing the "Enter" key on the "/settings/functions" page #7235
Comments
Hello @Devessier! |
bosiraphael
pushed a commit
that referenced
this issue
Sep 24, 2024
## Description - This PR solves the issue #7235 - On pressing enter, it automatically redirected to New function page in settings
Thanks @harshit078 and @ehconitin for your contribution. This issue has been solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
Wherever the focus is on the "/settings/functions" page, pressing the "Enter" key will always navigate to the "New Function" page. This breaks accessibility.
Example:
CleanShot.2024-09-24.at.12.24.03.mp4
Expected behavior
The page should not listen to the Enter key and let the browser behave naturally.
Technical inputs
Remove that code:
twenty/packages/twenty-front/src/modules/settings/serverless-functions/components/SettingsServerlessFunctionsTable.tsx
Lines 34 to 40 in fcaa9d9
The text was updated successfully, but these errors were encountered: