Fix: Remove 'Soon' integrations from Settings when disabled #7259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses issue #7110 by removing 'Soon' integrations (Airtable, Stripe, and PostgreSQL) from the Settings > Integrations page when they are disabled.
- Modified
getSettingsIntegrationAllin/packages/twenty-front/src/modules/settings/integrations/utils/getSettingsIntegrationAll.tsto conditionally include integrations based on their enabled status - Updated
useSettingsIntegrationCategoriesin/packages/twenty-front/src/modules/settings/integrations/hooks/useSettingsIntegrationCategories.tsto only show the "All" category if there's at least one integration enabled - Simplified integration types to 'Active' or 'Add', removing the 'Soon' status
- Improved user experience by displaying only available integrations in the settings
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
bosiraphael
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #7110, where Airtable, Stripe and PostgreSQL integrations were showing as "Soon" under Settings > Integrations.
Changes
getSettingsIntegrationAllso that when these integrations are disabled (via feature flags), they are removed from the list instead of showing as "Soon".useSettingsIntegrationCategoriesto only show the "All" category if there's at least one integration enabled.Notes
This is my first contribution to the project, so I'm open to feedback! 😄
Let me know if there's anything I should tweak or improve.