-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean the integration list (Remove Stripe, Airtable, PostgreSQL) #7110
Comments
Hello @Bonapara , I'll like to work on this, can you assign it to me? 😄 |
He will assign you soon till then go ahead and raise the PR @RaulErnesto08! |
Sure @RaulErnesto08, thanks for contributing! |
Hey there! Sorry for the late response, I was diving into the code and have a couple of questions. I noticed there are a few flags: The goal is to remove the Airtable, Stripe, and PostgreSQL integrations, but I'm wondering: Should I remove these integrations only when they are not enabled (when they are shown as "Soon")? I was thinking about adjusting the array in Current: return [
getSettingsIntegrationAll({
isAirtableIntegrationEnabled,
isAirtableIntegrationActive,
isPostgresqlIntegrationEnabled,
isPostgresqlIntegrationActive,
isStripeIntegrationEnabled,
isStripeIntegrationActive,
}),
SETTINGS_INTEGRATION_ZAPIER_CATEGORY,
SETTINGS_INTEGRATION_WINDMILL_CATEGORY,
SETTINGS_INTEGRATION_REQUEST_CATEGORY,
]; New: return [
SETTINGS_INTEGRATION_ZAPIER_CATEGORY,
SETTINGS_INTEGRATION_WINDMILL_CATEGORY,
SETTINGS_INTEGRATION_REQUEST_CATEGORY,
]; Does this approach make sense? or is there a better way to handle this? I'm sorry if this questions seems too obvious, is my first time contributing to this project and I want to make sure I'm following the best practices. Thanks in advance! |
@Bonapara, @RaulErnesto08, is this aligned with what you were suggesting? |
Thank you both for your messages. For V1, we can limit the removal to when they are displayed as "Soon" only, allowing users with an activated flag to access the integration settings. Does it make sense to you @ehconitin @RaulErnesto08? |
Yep makes sense!
@RaulErnesto08 Yes! |
## Description This PR addresses issue #7110, where Airtable, Stripe and PostgreSQL integrations were showing as "Soon" under Settings > Integrations. ## Changes - Update `getSettingsIntegrationAll` so that when these integrations are disabled (via feature flags), they are removed from the list instead of showing as "Soon". <img width="569" alt="Screenshot 2024-09-25 at 11 21 07 a m" src="https://github.com/user-attachments/assets/dae34e1f-b231-4e0c-bbd0-7d43a6a2f94a"> - Tweaked `useSettingsIntegrationCategories` to only show the "All" category if there's at least one integration enabled. <img width="582" alt="Screenshot 2024-09-25 at 11 21 15 a m" src="https://github.com/user-attachments/assets/57b87b18-8018-49e5-a507-527f2e6e701b"> ## Notes This is my first contribution to the project, so I'm open to feedback! 😄 Let me know if there's anything I should tweak or improve.
closed in #7259 |
Current behavior
In
Settings > Integrations
We display 3 integrations as coming soonDesired Behavior
Remove these three integrations (Airtable, Stripe, PostgreSQL) as they are no longer planned for the short term.
The text was updated successfully, but these errors were encountered: