Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calendar page without account #7256

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Sep 25, 2024

More details in this PR #7202

We(I) forgot to fix on the calendar page.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This change optimizes the calendar page functionality when no accounts are connected, preventing unnecessary API calls.

  • Added 'skip' parameter to useFindManyRecords hook in packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsCalendarChannelsContainer.tsx
  • Set skip condition to !accounts.length, avoiding query execution when no accounts are present
  • Improves performance by reducing unnecessary network requests when there's no data to fetch

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@ijreilly ijreilly merged commit 7669b40 into main Sep 25, 2024
7 of 10 checks passed
@ijreilly ijreilly deleted the c--fix-calendar-page-without-account branch September 25, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants