Fix IN filter with empty array #7202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses an issue with the IN filter handling empty arrays in the API and updates the frontend to optimize API calls accordingly.
- Modified
packages/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query-filter/graphql-query-filter-field.parser.tsto throw an error for empty arrays in IN filters - Updated
packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsMessageChannelsContainer.tsxto skip API calls when the accounts array is empty - Improved error handling in the backend to prevent unexpected behavior with empty IN filters
- Optimized frontend performance by avoiding unnecessary API requests for empty data sets
- Removed unused import and switched to native Array.isArray() method in the backend parser
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
thomtrp
approved these changes
Sep 23, 2024
| return; | ||
| if (operator === 'in') { | ||
| if (!Array.isArray(value)) { | ||
| return; |
charlesBochet
approved these changes
Sep 23, 2024
ijreilly
pushed a commit
that referenced
this pull request
Sep 25, 2024
More details in this PR #7202 We(I) forgot to fix on the calendar page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The api currently allows empty array in the IN filter but the expected behaviour is not very clear. Typeorm seems to return all records when it is empty which could lead to undesired result. Instead we decided to throw an error.
I've updated the FE accordingly to skip calls when array is empty.