fix: validate emails in record-fields #7245
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces email validation for record fields, addressing the issue of accepting any input as a valid email address.
- Added
validators.tswith email regex for consistent validation across components - Updated
EmailsFieldInput.tsxto use new validation logic, improving data integrity - Modified
MultiItemFieldInput.tsxto handle and display validation errors - Enhanced
DropdownMenuInput.tsxwith error display functionality for better user feedback - Implemented minimal field validation framework, focusing on email fields initially
5 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
...ront/src/modules/object-record/record-field/meta-types/input/components/EmailsFieldInput.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Hello @sid0-0! Thank you for contributing. For validation in the front end we use zod. You can look at an example of validation in packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsBlocklistInput.tsx. Could you use this framework for consistency with the rest of the codebase? Thank you :)
|
Actually, I'm not even sure that we want to constraint the inputs for the emails. I'll let @Bonapara or @FelixMalfait confirm. |
|
@bosiraphael I think it's cool to have it on the frontend. Ideally we would also have backend driven constraints but maybe it's okay to start with that for some field types. |
|
For V1, I think we should change the border to red instead of writing "invalid email" under the field. @sid0-0 can you manage that? Thanks for contributing!
|
|
Thanks @sid0-0 for your contribution! |
fix: twentyhq#7149 Introduced a minimal field validation framework for record-fields. Currently only shows errors for email field. <img width="350" alt="image" src="https://github.com/user-attachments/assets/1a1fa790-71a4-4764-a791-9878be3274f1"> <img width="347" alt="image" src="https://github.com/user-attachments/assets/e22d24f2-d1a7-4303-8c41-7aac3cde9ce8"> --------- Co-authored-by: sid0-0 <[email protected]> Co-authored-by: bosiraphael <[email protected]> Co-authored-by: Félix Malfait <[email protected]>
fix: #7149
Introduced a minimal field validation framework for record-fields.
Currently only shows errors for email field.