Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emails doesn't follow regex pattern in table #7149

Closed
harshit078 opened this issue Sep 19, 2024 · 2 comments · Fixed by #7245
Closed

Emails doesn't follow regex pattern in table #7149

harshit078 opened this issue Sep 19, 2024 · 2 comments · Fixed by #7245

Comments

@harshit078
Copy link
Contributor

Caution

User can add any email without any pattern.
On adding emails in Companies or People, the email doesn't follow any regex pattern and accepts any email.

Current behavior

Screenshot 2024-09-19 at 6 24 07 PM Screenshot 2024-09-19 at 6 26 49 PM

Expected behaviour

Screenshot 2024-09-19 at 6 25 32 PM
@sid0-0 sid0-0 mentioned this issue Sep 25, 2024
Merged
@Weiko Weiko added the blocked: design needed This doesn't seem right label Oct 1, 2024
@Weiko
Copy link
Member

Weiko commented Oct 1, 2024

FYI @Bonapara

@Bonapara
Copy link
Member

Bonapara commented Oct 1, 2024

Put some instructions as comment in the PR #7245 (comment)

@Bonapara Bonapara removed the blocked: design needed This doesn't seem right label Oct 1, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Oct 3, 2024
harshit078 pushed a commit to harshit078/twenty that referenced this issue Oct 14, 2024
@sid0-0 @bosiraphael
@FelixMalfait @harshit078
fix: validate emails in record-fields (twentyhq#7245)
62a14df 
fix: twentyhq#7149 

Introduced a minimal field validation framework for record-fields.
Currently only shows errors for email field.

<img width="350" alt="image"
src="https://github.com/user-attachments/assets/1a1fa790-71a4-4764-a791-9878be3274f1">
<img width="347" alt="image"
src="https://github.com/user-attachments/assets/e22d24f2-d1a7-4303-8c41-7aac3cde9ce8">

---------

Co-authored-by: sid0-0 <[email protected]>
Co-authored-by: bosiraphael <[email protected]>
Co-authored-by: Félix Malfait <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: validate emails in record-fields sid0-0/twenty
3 participants
@Weiko @Bonapara @harshit078