Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #6597 Created by field can't have null value #6614

Conversation

BOHEUS
Copy link
Contributor

@BOHEUS BOHEUS commented Aug 12, 2024

Fix for #6597

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updated createdByWorkspaceMemberId and createdByName fields for opportunities 1, 2, and 3 to ensure non-null values.

  • Modified packages/twenty-server/src/database/typeorm-seeds/workspace/opportunities.ts to change 'createdBy' fields from Jony Ive to Tim Cook.
  • Ensures 'createdBy' fields are populated with valid values, addressing null value issue.
  • Verify alignment with business logic and data consistency requirements.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks!

@FelixMalfait FelixMalfait merged commit 65a961f into twentyhq:main Aug 13, 2024
4 checks passed
Copy link

Thanks @BOHEUS for your contribution!
This marks your 2nd PR on the repo. You're top 13% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

@BOHEUS BOHEUS deleted the fix_6597_created_by_field_cant_have_null_value branch August 14, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants