-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2e): twenty-e2e-testing with playwright #6539
feat(e2e): twenty-e2e-testing with playwright #6539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Introduced end-to-end (E2E) testing for the twenty
project using Playwright, enhancing the testing capabilities and ensuring application stability.
- package.json: Added
twenty-e2e-testing
package to the monorepo for E2E testing. - packages/twenty-e2e-testing/.env.example: Introduced environment variable configuration for E2E tests.
- packages/twenty-e2e-testing/README.md: Provided detailed instructions for running E2E tests.
- packages/twenty-e2e-testing/e2e/companies.spec.ts: Added a basic test to verify table visibility on the
/objects/companies
page. - packages/twenty-e2e-testing/playwright.config.ts: Configured Playwright for E2E testing, including browser setups and parallel execution.
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
@@ -0,0 +1,2 @@ | |||
# Note that provide always without trailing forward slash to have expected behaviour | |||
FRONTEND_BASE_URL="http://localhost:3001" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Add a newline at the end of the file to follow best practices for text files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks doing lesss goo
@lucasbordeau I have few more questions before we can review this.
|
@Nabhag8848 Thanks, nice work.
|
You can let Firefox and Safari as they're already here. |
@lucasbordeau made changes 🔥, lemme know if we need any more changes. also we can work next on #4832 or on adding CI config, whichever has P0 priority. |
@Nabhag8848 Could you please check the problem with yarn and the CI ? It seems to be related to the packages you installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work thank you.
Thanks @Nabhag8848 for your contribution! |
ISSUE (e2e) - Introduces e2e for twenty
Description
Running test with UI
Screen.Recording.2024-08-05.at.5.57.09.PM.mov
Running all test and seeing report
Screen.Recording.2024-08-05.at.5.58.26.PM.mov