Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup E2E testing #6360

Closed
3 tasks
lucasbordeau opened this issue Jul 22, 2024 · 5 comments · Fixed by #6539
Closed
3 tasks

Setup E2E testing #6360

lucasbordeau opened this issue Jul 22, 2024 · 5 comments · Fixed by #6539
Labels
good first issue Good for newcomers

Comments

@lucasbordeau
Copy link
Contributor

Twenty starts to have a lot of features and different use cases to test.

When doing refactors we usually try to test the app manually to make sure everything is working as expected.

But as it can now take a long time, we would like to have at least manual e2e tests to launch locally while developing or reviewing PR that involve refactors.

We already have integration tests with storybook and a lot of unit tests with jest, we also have visual regression testing with chromatic.

So e2e should focus on the most basics things to detect bugs :

  • Ensuring login works
  • Ensuring there's no bug or errors when we visit each page
  • Ensuring different workflows are executing without bugs or errors

Where e2e would compound efficiently is to offer us a minimal test coverage on a lot of small workflows because tests are easy to write.

We would see later how to integrate this in CI as it is not the main priority right now.

TODO :

  • Create a new package twenty-e2e-testing and install playwright following its documentation
  • Setup environment variables for the base url, etc.
  • Create a basic test that visits /objects/companies and that verifies there's a table shown
@lucasbordeau lucasbordeau added the good first issue Good for newcomers label Jul 22, 2024
@BarryByte
Copy link

Hey @lucasbordeau I would like to take this issue, please assign it to me.

@pacyL2K19
Copy link
Contributor

Any chance I can work on this issue?
@Bonapara @lucasbordeau

@lucasbordeau
Copy link
Contributor Author

@BarryByte I'll assign you since you're first.

@Nabhag8848
Copy link
Contributor

hey @BarryByte just checking, are you still working on it and made some progress? let us know if its available to take, I'm interested to work on this, also just want to mention, making draft PRs are great way to avoid this workflow.

cc @lucasbordeau

@BarryByte
Copy link

sorry, currently i am unable to do take this forward. @lucasbordeau Please assign @Nabhag8848 for this issue. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants