"Name" column is visible on table view but not on kanban view

[gitstart-app]

This PR was created by GitStart to address the requirements from this ticket: TWNTY-4238.
This ticket was imported from: TWNTY-4238

---

Description

• We moved the filter from RecordIndexContainer to RecordBoardCard, this change will fix the fix issue that the name column was not visible in Kanban view and will keep the behavior in the Kanban card. The options dropdown uses the same state that the card uses, but the name is rendered on the card because, for the name field, the card uses another data because the render of the name is different from the render of the other fields, so we removed the filter in the state, but we need to filter only in the card to avoid duplicated data, we could not find any other case that this filter is useful for another component
• We updated the type in RecordBoardFieldDefinition to fix TS error in RecordBoardCard file

Demo

https://jam.dev/c/7c9db8e1-9b53-49cf-a44c-0b0fec5b1988

Refs

• "Name" column is visible on table view but not on kanban view #4238

Fixes #4238

[greptile-apps]

PR Summary

This PR addresses the visibility issue of the "Name" column in the Kanban view by adjusting the filtering logic in relevant components.

• packages/twenty-front/src/modules/object-record/record-board/record-board-card/components/RecordBoardCard.tsx:

  • Added filtering logic to exclude fields marked as isLabelIdentifier from visibleFieldDefinitions.

• packages/twenty-front/src/modules/object-record/record-board/types/RecordBoardFieldDefinition.ts:

  • Introduced an optional boolean property isLabelIdentifier to the RecordBoardFieldDefinition type.

• packages/twenty-front/src/modules/object-record/record-index/components/RecordIndexContainer.tsx:

  • Removed the filter excluding isLabelIdentifier fields from newFieldDefinitions, ensuring the name column is visible in both views.

_{3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

This PR addresses the visibility issue of the "Name" column in the Kanban view by adjusting the filtering logic in relevant components.

• packages/twenty-front/src/modules/object-record/record-board/record-board-card/components/RecordBoardCard.tsx:

  • Added filtering logic to exclude fields marked as isLabelIdentifier from visibleFieldDefinitions.

• packages/twenty-front/src/modules/object-record/record-board/types/RecordBoardFieldDefinition.ts:

  • Introduced an optional boolean property isLabelIdentifier to the RecordBoardFieldDefinition type.

• packages/twenty-front/src/modules/object-record/record-index/components/RecordIndexContainer.tsx:

  • Removed the filter excluding isLabelIdentifier fields from newFieldDefinitions, ensuring the name column is visible in both views.

_{3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[charlesBochet]

LGTM, thank you!

[github-actions]

	Fails
🚫	node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-97b1aa8d.json

Generated by 🚫 dangerJS against 2957c14