Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Name" column is visible on table view but not on kanban view #4238

Closed
FelixMalfait opened this issue Feb 29, 2024 · 3 comments · Fixed by #6427
Closed

"Name" column is visible on table view but not on kanban view #4238

FelixMalfait opened this issue Feb 29, 2024 · 3 comments · Fixed by #6427
Assignees
Labels
scope: front Issues that are affecting the frontend side only

Comments

@FelixMalfait
Copy link
Member

list view

Screenshot 2024-02-29 at 10 52 57

Table view

Name is displayed on the card but it's not visible on the field

Screenshot 2024-02-29 at 10 53 34 Screenshot 2024-02-29 at 10 53 54
@FelixMalfait FelixMalfait added the scope: front Issues that are affecting the frontend side only label Feb 29, 2024
@FelixMalfait FelixMalfait added the T label May 20, 2024
@FelixMalfait
Copy link
Member Author

FelixMalfait commented Jul 16, 2024

Note ideally this shouldn't be hardcoded be refer to the label identifier column.
It seems to be the case already
Screenshot 2024-07-16 at 17 28 45

As in table view it should be displayed at the top / not be draggable / be disabled

Screenshot 2024-07-16 at 17 25 21

@FelixMalfait
Copy link
Member Author

@gitstart-twenty assigning you but but if the root cause can't be fixed cleanly we can close this issue, we only want to fix this if it can be done in a clean way

Copy link
Contributor

gitstart-app bot commented Jul 16, 2024

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-4238

charlesBochet pushed a commit that referenced this issue Jul 27, 2024
This PR was created by [GitStart](https://gitstart.com/) to address the
requirements from this ticket:
[TWNTY-4238](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-4238).
This ticket was imported from:
[TWNTY-4238](#4238)

 --- 

## Description

- We moved the filter from RecordIndexContainer to RecordBoardCard, this
change will fix the fix issue that the name column was not visible in
Kanban view and will keep the behavior in the Kanban card. The options
dropdown uses the same state that the card uses, but the name is
rendered on the card because, for the name field, the card uses another
data because the render of the name is different from the render of the
other fields, so we removed the filter in the state, but we need to
filter only in the card to avoid duplicated data, we could not find any
other case that this filter is useful for another component
- We updated the type in RecordBoardFieldDefinition to fix TS error in
RecordBoardCard file

### Demo

<https://jam.dev/c/7c9db8e1-9b53-49cf-a44c-0b0fec5b1988>

### Refs

- #4238

Fixes #4238

Co-authored-by: gitstart-twenty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: front Issues that are affecting the frontend side only
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants