Add Confirmation Modal for Deletion Action and Map All Action Bar Entries

[falko100]

This pull request addresses an issue where the delete button, placed closely to the export button, could lead to accidental deletions without confirmation. The problem was that the confirmation modal for the delete action, being the second action, was not displayed. The code was updated to map all action bar entries and display their respective confirmation modals correctly.

Changes Made:

• Updated the rendering of action bar entries to ensure all confirmation modals are shown.
  Changed from displaying only the first action bar entry's confirmation modal to mapping through all entries and displaying each modal if it exists.
• Removed the delete from the onClick because it is present in the onConfirmClick.

[greptile-apps]

PR Summary

Ensured all action bar entries display their respective confirmation modals, particularly addressing the delete action.

• Modified packages/twenty-front/src/modules/object-record/record-action-bar/hooks/useRecordActionBar.tsx to map through all action bar entries and display each confirmation modal if it exists.
• Removed the delete action from the onClick handler and moved it to the onConfirmClick handler.
• Updated packages/twenty-front/src/modules/ui/navigation/shared/components/NavigationModal.tsx to render confirmation modals for all action bar entries.

_{2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[ijreilly]

@falko100 thanks for your contribution! Just checking-in with product if they are fine with this behavior and warning message.

@Bonapara what do you think? Is this something we will want for all deletion operations (eg field/object deletion in the data model)?

Enregistrement.de.l.ecran.2024-07-22.a.12.17.40.mov

[Bonapara]

@ijreilly I think this is okay for now, as there is a kind of soft-delete (Disabling) for the fields and object deletion. However, for records, there is no soft delete yet.

[onavhamid]

Hi. Did this PR add a warning when deleting an ppportunity? (i.e. using the upper-right button)

Recently tried to delete a Task inside an opportunity and accidentally deleted the entire opportunity. Having a confirmation or warning would have helped.