Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete confirmation dialog for object detail view #6559

Closed
Taldres opened this issue Aug 6, 2024 · 3 comments
Closed

Add delete confirmation dialog for object detail view #6559

Taldres opened this issue Aug 6, 2024 · 3 comments

Comments

@Taldres
Copy link

Taldres commented Aug 6, 2024

Current behavior

When I click on the delete button at the top right of an object detail page, it will instantly delete the selected record without any confirmation.

Bildschirmfoto 2024-08-06 um 19 06 36

Expected behavior

A confirmation dialog should appear, similar to the one in listings via the action bar delete button, as implemented in the latest release. This is the PR of the mentioned implementation: Add Confirmation Modal for Deletion Action and Map All Action Bar Entries #6357

Bildschirmfoto 2024-08-06 um 19 07 03

@FelixMalfait
Copy link
Member

@Taldres agree we could have built this! We didn't prioritize it because we want to work on #4956 instead, which is more difficult but more powerful. @magrinj will work on that when he comes back in September

@Taldres
Copy link
Author

Taldres commented Aug 6, 2024

@FelixMalfait thank you for your quick response. I just wanted to let you know that it would be great to get, but soft-deletes are absolutely worth the wait 🙌.

@FelixMalfait
Copy link
Member

Closing in favor of #4956
#6576 a v1 of soft delete is coming soon, very likely to be in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants