-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mobile Navigation bar css for better usage #6209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Made
NavigationBar
fixed at the bottom on mobile (/packages/twenty-front/src/modules/ui/navigation/navigation-bar/components/NavigationBar.tsx
) - Added background color to
NavigationBar
for better visibility on mobile (/packages/twenty-front/src/modules/ui/navigation/navigation-bar/components/NavigationBar.tsx
) - Introduced bottom margin to
RecordTable
on mobile to prevent last entries from being hidden (/packages/twenty-front/src/modules/object-record/record-table/components/RecordTable.tsx
) - Utilized
useIsMobile
hook to conditionally apply styles (/packages/twenty-front/src/modules/object-record/record-table/components/RecordTable.tsx
)
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Log
|
Thanks for the contribution! I don't think that's the issue, it's probably this instead: https://www.reddit.com/r/css/comments/12mh0ac/safari_mobile_does_not_respect_height_100vh/ ; I will make a quick fix |
This reverts commit bc9da9c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Removed
useIsMobile
hook and mobile-specific margin adjustment in/packages/twenty-front/src/modules/object-record/record-table/components/RecordTable.tsx
- Removed fixed positioning and background color from
StyledContainer
in/packages/twenty-front/src/modules/ui/navigation/navigation-bar/components/NavigationBar.tsx
- Added
margin-bottom
toNavigationBar
to prevent last entries from being hidden on mobile
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
@Bonapara fyi changing most |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Updated height property from
100vh
to100dvh
in multiple files for better mobile viewport handling (/packages/twenty-front/src/loading/components/LeftPanelSkeletonLoader.tsx
,/packages/twenty-front/src/loading/components/UserOrMetadataLoader.tsx
,/packages/twenty-front/src/modules/ui/feedback/dialog-manager/components/Dialog.tsx
,/packages/twenty-front/src/modules/ui/layout/page/BlankLayout.tsx
,/packages/twenty-front/src/modules/ui/layout/page/DefaultLayout.tsx
,/packages/twenty-front/src/pages/auth/Authorize.tsx
) - Reordered import statements in
/packages/twenty-front/src/loading/components/LeftPanelSkeletonLoader.tsx
and/packages/twenty-front/src/modules/ui/layout/page/DefaultLayout.tsx
for better code organization
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Closes #5744
Description
margin-bottom
so, last entries doesn't get hidden.