Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Bar Not Visible on Mobile Without Scrolling #5744

Closed
Bonapara opened this issue Jun 5, 2024 · 6 comments · Fixed by #6209
Closed

Bottom Bar Not Visible on Mobile Without Scrolling #5744

Bonapara opened this issue Jun 5, 2024 · 6 comments · Fixed by #6209
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@Bonapara
Copy link
Member

Bonapara commented Jun 5, 2024

Current Behavior

The bottom bar is not directly visible on mobile. To see it, I have to scroll the page by placing my finger at the extreme edge of the screen.

RPReplay_Final1717576568.MP4

Desired Behavior

The bottom bar should always be visible. Use LVH or other modern CSS viewport units to account for the browser's collapsing navbar.

@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes labels Jun 5, 2024
Copy link
Contributor

greptile-apps bot commented Jun 5, 2024

Disclaimer: This comment was automatically generated with AI. It can give some useful hints as to where to look for, but sometimes it can also give very inaccurate answers so takes this with a pinch of salt :).

To ensure the bottom bar is always visible on mobile devices, follow these steps:

  1. File: src/components/DefaultLayout.tsx

    • Locate the bottom bar component within the layout.
    • Ensure it uses modern CSS viewport units like lvh.
  2. File: src/components/TopBar.tsx

    • Adjust the styling to ensure it does not interfere with the bottom bar visibility.
  3. File: src/hooks/responsive/useIsMobile.ts

    • Utilize this hook to apply conditional styling for mobile devices.
  4. CSS Adjustment:

    • Update the relevant styled components to use lvh units for height calculations.

Example:

bottom-bar {
  height: 10lvh;
  position: fixed;
  bottom: 0;
  width: 100%;
}

References

@OHSOHYEON00
Copy link

Hi, Can I work on this? @Bonapara

@Bonapara
Copy link
Member Author

Bonapara commented Jun 6, 2024

Sure @OHSOHYEON00, thanks for contributing (Again!) :)

@Bonapara
Copy link
Member Author

Bonapara commented Jul 2, 2024

Hi @OHSOHYEON00, are you still working on this? I'm unassigning you, but let me know if you still want to handle it!

@dhruvdabhi101
Copy link
Contributor

Hey, If no one is working, then can you please assign this issue? i might want to give it a try. Thanks : )

@Bonapara
Copy link
Member Author

Sure @dhruvdabhi101, thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants