Fix/disable cancel button on save #6204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a `isCancelDisabled` prop to the `CancelButton` component - update the prop in related pages: new object, edit object, new field and edit field pages
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Introduced
disabledprop toCancelButtonin/packages/twenty-front/src/modules/settings/components/SaveAndCancelButtons/CancelButton.tsx - Added
isCancelDisabledprop toSaveAndCancelButtonsin/packages/twenty-front/src/modules/settings/components/SaveAndCancelButtons/SaveAndCancelButtons.tsx - Disabled cancel button during form submission in
/packages/twenty-front/src/pages/settings/data-model/SettingsNewObject.tsx - Disabled cancel button during form submission in
/packages/twenty-front/src/pages/settings/data-model/SettingsObjectEdit.tsx - Disabled cancel button during form submission in
/packages/twenty-front/src/pages/settings/data-model/SettingsObjectFieldEdit.tsx
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Refetch queries after navigating to the object page for data consistency (
/packages/twenty-front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep2.tsx) - Disable cancel button during form submission to prevent user actions (
/packages/twenty-front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep2.tsx)
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
FelixMalfait
approved these changes
Jul 11, 2024
|
Thanks @pacyL2K19 for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Similarly to #5673 I have improved the field creation time by re-fetching data on page redirection to the object page
@FellipeMTX @Bonapara