feat (improvement): update the createOneObjectMetaItem #5673
Conversation
… for faster queries
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Updated
createOneObjectMetadataItemhook to reduce API calls - Added
findManyRecordsCachefunction for background cache updates - Improved user navigation by caching data post-navigation
- Enhanced user experience by reducing create object API call time
- Modified
SettingsNewObject.tsxto integrate new caching strategy
|
Hi @pacyL2K19, Thanks for the PR 🙌. Disabling the button instead of setting a loader could work, but could you deactivate the |
Hi @Bonapara |
There was a problem hiding this comment.
@pacyL2K19 thanks for your contribution ! 🔥
The logic is already there to disable the button indeed.
Closing this issue @Bonapara !
|
Thanks @pacyL2K19 for your contribution! |
# This PR - Fix twentyhq#5278 - Updates the implementation of the `createOneObjectMataItem` hook to reduce the number of api calls - Users can now navigate to the newly created object first and the graphql api calls to cache data are happening in the background - this will improve the user experience and reduce the create object api call time by >2 <img width="1508" alt="Screenshot 2024-05-30 at 12 00 15" src="https://github.com/twentyhq/twenty/assets/61581306/46513fd1-d46e-40bc-a036-07e3acdf2870"> In the issue description, it also suggested to have a loading indicator while creating the object, it seems like on twentyhq#5352 we adopted to disable it while creating the object - which looks good to me and it works, let me know if we still need the loading indicator instead @Bonapara Looking forward to getting your feedback cc: @charlesBochet --------- Co-authored-by: Thomas Trompette <[email protected]>
# This PR - Fix #5675 - Fix #6118 Similarly to #5673 I have improved the field creation time by re-fetching data on page redirection to the object page <img width="1511" alt="Screenshot 2024-07-10 at 16 06 37" src="https://github.com/twentyhq/twenty/assets/61581306/8ef8f4cb-4334-4f4c-b5d9-fea11fd5d99a"> @FellipeMTX @Bonapara --------- Co-authored-by: Félix Malfait <[email protected]>
# This PR - Fix twentyhq#5278 - Updates the implementation of the `createOneObjectMataItem` hook to reduce the number of api calls - Users can now navigate to the newly created object first and the graphql api calls to cache data are happening in the background - this will improve the user experience and reduce the create object api call time by >2 <img width="1508" alt="Screenshot 2024-05-30 at 12 00 15" src="https://github.com/twentyhq/twenty/assets/61581306/46513fd1-d46e-40bc-a036-07e3acdf2870"> In the issue description, it also suggested to have a loading indicator while creating the object, it seems like on twentyhq#5352 we adopted to disable it while creating the object - which looks good to me and it works, let me know if we still need the loading indicator instead @Bonapara Looking forward to getting your feedback cc: @charlesBochet --------- Co-authored-by: Thomas Trompette <[email protected]>
This PR
createOneObjectMataItemhook to reduce the number of api callsIn the issue description, it also suggested to have a loading indicator while creating the object, it seems like on #5352 we adopted to disable it while creating the object - which looks good to me and it works, let me know if we still need the loading indicator instead @Bonapara
Looking forward to getting your feedback
cc: @charlesBochet