-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Snackbar as shown in Figma Fixes #5666 #5700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Updated
SnackBar
component to align with Figma design - Added
children
prop toLightButton
for more complex content - Enhanced
LightIconButton
withchildren
prop and adjusted styles
Log
|
thomtrp
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing @sagarhedaoo! Adding a children was not part of this issue so I removed it
piyushyadav1617
pushed a commit
to piyushyadav1617/twenty
that referenced
this pull request
Jun 3, 2024
<img width="282" alt="Screenshot 2024-06-01 at 1 07 16 AM" src="https://github.com/twentyhq/twenty/assets/10000167/0b1cd2f5-9036-4a31-8dfa-b90972ebe1aa"> Updated the font weight and added Cancel label on the left of the icon as shown in figma design. Also, didn't increased the gap because it's already like the figma design! Let me know if you want more gap between title and description. Closes twentyhq#5666 --------- Co-authored-by: Thomas Trompette <[email protected]>
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
<img width="282" alt="Screenshot 2024-06-01 at 1 07 16 AM" src="https://github.com/twentyhq/twenty/assets/10000167/0b1cd2f5-9036-4a31-8dfa-b90972ebe1aa"> Updated the font weight and added Cancel label on the left of the icon as shown in figma design. Also, didn't increased the gap because it's already like the figma design! Let me know if you want more gap between title and description. Closes twentyhq#5666 --------- Co-authored-by: Thomas Trompette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the font weight and added Cancel label on the left of the icon as shown in figma design.
Also, didn't increased the gap because it's already like the figma design!
Let me know if you want more gap between title and description.
Closes #5666