Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snackbar font-weight & spacing #5666

Closed
Bonapara opened this issue May 29, 2024 · 3 comments · Fixed by #5700
Closed

Snackbar font-weight & spacing #5666

Bonapara opened this issue May 29, 2024 · 3 comments · Fixed by #5700
Assignees
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@Bonapara
Copy link
Member

Current behavior

image

Desired Behavior

CleanShot 2024-05-29 at 18 48 53

  1. The snackbar title font weight should be medium instead of regular
  2. The gap between the snack bar title and description is bigger than on Figma. Make sure to align with Figma design.
@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes labels May 29, 2024
Copy link
Contributor

greptile-apps bot commented May 29, 2024

Disclaimer: This comment was automatically generated with AI. It can give some useful hints as to where to look for, but sometimes it can also give very inaccurate answers so takes this with a pinch of salt :).

To address the Snackbar font-weight and spacing issue:

  1. Update Font Weight:

    • Locate the Snackbar component in src/components/Snackbar.tsx.
    • Find the title element and update its font weight to medium.
    <Title style={{ fontWeight: '500' }}> {/* Adjust font weight to medium */}
  2. Adjust Spacing:

    • In the same file, adjust the margin or padding between the title and description to match the Figma design.
    <Title style={{ marginBottom: '8px' }}> {/* Adjust spacing as per Figma */}

Ensure these changes align with the design specifications provided in Figma.

References

@sagarhedaoo
Copy link
Contributor

Hi @Bonapara Can you assign it to me? I can fix it!

@Bonapara
Copy link
Member Author

Sure @sagarhedaoo, thanks for contributing!

sagarhedaoo added a commit to sagarhedaoo/twenty that referenced this issue Jun 1, 2024
thomtrp added a commit that referenced this issue Jun 3, 2024
<img width="282" alt="Screenshot 2024-06-01 at 1 07 16 AM"
src="https://github.com/twentyhq/twenty/assets/10000167/0b1cd2f5-9036-4a31-8dfa-b90972ebe1aa">


Updated the font weight and added Cancel label on the left of the icon
as shown in figma design.
Also, didn't increased the gap because it's already like the figma
design!
Let me know if you want more gap between title and description.

Closes #5666

---------

Co-authored-by: Thomas Trompette <[email protected]>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Jun 3, 2024
piyushyadav1617 pushed a commit to piyushyadav1617/twenty that referenced this issue Jun 3, 2024
<img width="282" alt="Screenshot 2024-06-01 at 1 07 16 AM"
src="https://github.com/twentyhq/twenty/assets/10000167/0b1cd2f5-9036-4a31-8dfa-b90972ebe1aa">


Updated the font weight and added Cancel label on the left of the icon
as shown in figma design.
Also, didn't increased the gap because it's already like the figma
design!
Let me know if you want more gap between title and description.

Closes twentyhq#5666

---------

Co-authored-by: Thomas Trompette <[email protected]>
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this issue Oct 6, 2024
<img width="282" alt="Screenshot 2024-06-01 at 1 07 16 AM"
src="https://github.com/twentyhq/twenty/assets/10000167/0b1cd2f5-9036-4a31-8dfa-b90972ebe1aa">


Updated the font weight and added Cancel label on the left of the icon
as shown in figma design.
Also, didn't increased the gap because it's already like the figma
design!
Let me know if you want more gap between title and description.

Closes twentyhq#5666

---------

Co-authored-by: Thomas Trompette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants