Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Icon Width on Menu Items #5678 #5688

Merged
merged 1 commit into from
May 31, 2024
Merged

Incorrect Icon Width on Menu Items #5678 #5688

merged 1 commit into from
May 31, 2024

Conversation

Sudarsh1010
Copy link
Contributor

Fixes #5678

@Sudarsh1010 Sudarsh1010 marked this pull request as draft May 31, 2024 05:58
greptile-apps[bot]
greptile-apps bot reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Updated IconChevronRight size to md in MenuItemNavigate
  • Changed selected state icon size to md in MenuItemSelect
  • Adjusted IconCheck size to md in MenuItemSelectAvatar
  • Modified IconCheck size to md in MenuItemSelectColor

@Sudarsh1010 Sudarsh1010 marked this pull request as ready for review May 31, 2024 05:59
greptile-apps[bot]
greptile-apps bot reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Updated IconChevronRight size to md in MenuItemNavigate
  • Updated IconCheck size to md in MenuItemSelect
  • Updated IconCheck size to md in MenuItemSelectAvatar
  • Updated IconCheck size to md in MenuItemSelectColor

martmull
martmull approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FelixMalfait
Copy link
Member

Thank you! Merging like this

FYI @Bonapara we don't have a square div around the svg. This updates the size only.

@FelixMalfait FelixMalfait merged commit c960d2e into twentyhq:main May 31, 2024
3 checks passed
@Bonapara
Copy link
Member

🙏 @FelixMalfait, doesn't work the same way in Figma

@Sudarsh1010 Sudarsh1010 deleted the icon-size-fix branch May 31, 2024 16:41
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this pull request Oct 6, 2024
@Sudarsh1010
Incorrect Icon Width on Menu Items twentyhq#5678 (twentyhq#5688)
6ed6ebd 
Fixes twentyhq#5678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@martmull martmull martmull approved these changes

Assignees

@lucasbordeau lucasbordeau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Icon Width on Menu Items
6 participants
@Sudarsh1010 @FelixMalfait @Bonapara @martmull @charlesBochet @lucasbordeau