Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Icon Width on Menu Items #5678

Closed
Bonapara opened this issue May 30, 2024 · 3 comments · Fixed by #5688
Closed

Incorrect Icon Width on Menu Items #5678

Bonapara opened this issue May 30, 2024 · 3 comments · Fixed by #5688
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@Bonapara
Copy link
Member

Bonapara commented May 30, 2024

Current behavior

The icon width on menu items with an icon on their right edge* is wrongly fixed to 12.5px, even if 14px is specified in their width

*MenuItem Navigate
*MenuItem Select
*MenuItem Select Avatar
*MenuItem Select Color

CleanShot 2024-05-30 at 15 02 55
CleanShot 2024-05-30 at 15 19 30

Desired Behavior

  1. Their size should be 16px by 16px (not 14px by 14px).
  2. The browser should consider this specified width (and not set 12.5px for unknown reasons)

image

@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes labels May 30, 2024
Copy link
Contributor

greptile-apps bot commented May 30, 2024

Disclaimer: This comment was automatically generated with AI. It can give some useful hints as to where to look for, but sometimes it can also give very inaccurate answers so takes this with a pinch of salt :).

To fix the icon width issue on menu items, follow these steps:

  1. MenuItemNavigate.tsx: Update the IconChevronRight size to 16px.
<IconChevronRight size={16} />
  1. MenuItemSelect.tsx: Update the IconCheck size to 16px.
{selected && <IconCheck size={16} />}
  1. MenuItemSelectAvatar.tsx: Update the IconCheck size to 16px.
{selected && <IconCheck size={16} />}
  1. MenuItemSelectColor.tsx: Update the IconCheck size to 16px.
{selected && <IconCheck size={16} />}

Ensure these changes are applied to the respective files to achieve the desired icon size.

References

/packages/twenty-front/src/modules/ui/navigation/menu-item/components/MenuItemNavigate.tsx
/packages/twenty-front/src/modules/ui/navigation/menu-item/components/MenuItemSelect.tsx
/packages/twenty-front/src/modules/ui/navigation/menu-item/components/MenuItemSelectAvatar.tsx
/packages/twenty-front/src/modules/ui/navigation/menu-item/components/MenuItemSelectColor.tsx
/packages/twenty-front/src/modules/ui/navigation/menu-item/internals

Ask Greptile

@Sudarsh1010
Copy link
Contributor

I would like to take this issue

@Bonapara
Copy link
Member Author

Sure @Sudarsh1010, thanks for contributing!

FelixMalfait pushed a commit that referenced this issue May 31, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ May 31, 2024
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this issue Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants