Fix transliteration for metadata + transliterate select options #5430
Conversation
|
|
||
| export const transliterateLabel = (label: string) => | ||
| formatLabelOrThrows(label, OPTION_VALUE_VALID_STRING_PATTERN); | ||
|
|
||
| export const getOptionValueFromLabel = (label: string) => { |
There was a problem hiding this comment.
we don't want to throw here as this needs to be evaluated before save-time to generate the option value as we type; unlike in the object/fields forms where the transliteration only needs to be performed at save-time
ijreilly
requested review from
charlesBochet and
thaisguigon
and removed request for
charlesBochet
| import { OPTION_VALUE_VALID_STRING_PATTERN } from '~/pages/settings/data-model/utils/constants.utils'; | ||
| import { formatLabelOrThrows } from '~/pages/settings/data-model/utils/format-label.util'; | ||
|
|
||
| export const transliterateLabel = (label: string) => |
There was a problem hiding this comment.
remove this function and only use formatLabelOrThrows
| OPTION_VALUE_VALID_STRING_PATTERN, | ||
| } from '~/pages/settings/data-model/utils/constants.utils'; | ||
|
|
||
| describe('METADATA_NAME_VALID_STRING_PATTERN', () => { |
There was a problem hiding this comment.
instead of testing regex, introduce computeMetadataNameFromLabelOrThrow(), computeSelectOptionValueOrThrow
computeMetadataNameFromLabelOrThrow = (string) => transliterateAndValidFormatOrThrow(string, VALID_PATTERN)
rename: formatLabelOrThrow(string, VALID_PATTERN) ==> transliterateAndValidFormatOrThrow(string, VALID_PATTERN)
| @@ -4,7 +4,7 @@ import { | |||
| ValidationArguments, | |||
| } from 'class-validator'; | |||
|
|
|||
| const graphQLEnumNameRegex = /^[_A-Za-z][_0-9A-Za-z]+$/; | |||
| const graphQLEnumNameRegex = /^[_A-Za-z][_0-9A-Za-z]*$/; | |||
There was a problem hiding this comment.
@magrinj are you ok with this update? One-char long names are not an issue with graphql
…tyhq#5430) ## Context Fixes twentyhq#5403 Transliteration is now integrated to form validation through the schema. While it does not impede inputting an invalid value, it impedes submitting a form that will fail as the transliteration is not possible. Until then we were only performing the transliteration at save time in the front-end, but it's best to provide the information as soon as possible. Later we will add helpers to guide the user (eg "This name is not valid": twentyhq#5428). --------- Co-authored-by: Charles Bochet <[email protected]>
Context
Fixes #5403
Transliteration is now integrated to form validation through the schema. While it does not impede inputting an invalid value, it impedes submitting a form that will fail as the transliteration is not possible. Until then we were only performing the transliteration at save time in the front-end, but it's best to provide the information as soon as possible. Later we will add helpers to guide the user (eg "This name is not valid": #5428).