Add error helpers for metadata settings inputs in form #5428
Assignees
Labels
good first issue
Good for newcomers
Comments
|
We should use this design! https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=3007-69739&t=vYBsvz4IWvZL44UI-11 |
charlesBochet
added a commit
that referenced
this issue
May 15, 2024
## Context Fixes #5403 Transliteration is now integrated to form validation through the schema. While it does not impede inputting an invalid value, it impedes submitting a form that will fail as the transliteration is not possible. Until then we were only performing the transliteration at save time in the front-end, but it's best to provide the information as soon as possible. Later we will add helpers to guide the user (eg "This name is not valid": #5428). --------- Co-authored-by: Charles Bochet <[email protected]>
|
@Bonapara this is closed? |
|
No! I just assigned you to it. Let me know if you don't want to handle it. If you do, thank you for contributing! |
|
Thanks @Bonapara will be happy to contribute, will ask if need any help |
|
Hi @t007rushi , thank you for your interest in twenty! |
|
No issues @ijreilly |
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this issue
Oct 6, 2024
…tyhq#5430) ## Context Fixes twentyhq#5403 Transliteration is now integrated to form validation through the schema. While it does not impede inputting an invalid value, it impedes submitting a form that will fail as the transliteration is not possible. Until then we were only performing the transliteration at save time in the front-end, but it's best to provide the information as soon as possible. Later we will add helpers to guide the user (eg "This name is not valid": twentyhq#5428). --------- Co-authored-by: Charles Bochet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Scope & Context
For now we are impeding users from trying to save an Object, a field or an option if the inputted value is not valid (because it starts with a digit or only contains empty char or is not transliterable, depending on the concerned data object). Let's add helpers in the form to help them understand what is wrong with their value (ex: "This field cannot be empty" / "Object names cannot start with digits".).
Expected behaviour can be clarified with @Bonapara
The text was updated successfully, but these errors were encountered: